Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3684)

Unified Diff: ash/virtual_keyboard_controller_unittest.cc

Issue 800933002: Turns on smart deployment of the virtual keyboard by default, and changes the flag to allow easy di… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/virtual_keyboard_controller.cc ('k') | chrome/app/generated_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/virtual_keyboard_controller_unittest.cc
diff --git a/ash/virtual_keyboard_controller_unittest.cc b/ash/virtual_keyboard_controller_unittest.cc
index dc45cc1413f4feeeff2d162441b667bbc1714822..08c054ce6f36ffbcd64bb0f5a0339be8310a4e8e 100644
--- a/ash/virtual_keyboard_controller_unittest.cc
+++ b/ash/virtual_keyboard_controller_unittest.cc
@@ -40,6 +40,8 @@ class VirtualKeyboardControllerTest : public AshTestBase {
}
void SetUp() override {
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ keyboard::switches::kDisableSmartVirtualKeyboard);
AshTestBase::SetUp();
UpdateKeyboardDevices(std::vector<ui::KeyboardDevice>());
UpdateTouchscreenDevices(std::vector<ui::TouchscreenDevice>());
@@ -70,9 +72,9 @@ class VirtualKeyboardControllerAutoTest : public VirtualKeyboardControllerTest,
~VirtualKeyboardControllerAutoTest() override {}
void SetUp() override {
- CommandLine::ForCurrentProcess()->AppendSwitch(
- keyboard::switches::kAutoVirtualKeyboard);
- VirtualKeyboardControllerTest::SetUp();
+ AshTestBase::SetUp();
+ UpdateKeyboardDevices(std::vector<ui::KeyboardDevice>());
+ UpdateTouchscreenDevices(std::vector<ui::TouchscreenDevice>());
sadrul 2014/12/12 21:22:44 Add a comment explaining why these are necessary.
rsadam 2014/12/12 22:10:22 Done.
Shell::GetInstance()->system_tray_notifier()->AddVirtualKeyboardObserver(
this);
}
« no previous file with comments | « ash/virtual_keyboard_controller.cc ('k') | chrome/app/generated_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698