Turns on smart deployment of the virtual keyboard by default, and changes the flag to allow easy di…

ash/virtual_keyboard_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/virtual_keyboard_controller.h"
 
 #include <vector>
 
 #include "ash/shell.h"
 #include "ash/wm/maximize_mode/maximize_mode_controller.h"
@@ skipping 18 matching lines @@
   ui::DeviceDataManager::GetInstance()->AddObserver(this);
   UpdateDevices();
 }
 
 VirtualKeyboardController::~VirtualKeyboardController() {
   Shell::GetInstance()->RemoveShellObserver(this);
   ui::DeviceDataManager::GetInstance()->RemoveObserver(this);
 }
 
 void VirtualKeyboardController::OnMaximizeModeStarted() {
-  if (!CommandLine::ForCurrentProcess()->HasSwitch(
-          keyboard::switches::kAutoVirtualKeyboard)) {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          keyboard::switches::kDisableSmartVirtualKeyboard)) {

[sky, 2014/12/13 00:12:24]

Can we have this check in one place and not three?

[rsadam, 2014/12/13 00:35:27]

Done.

     SetKeyboardEnabled(true);
   }
 }
 
 void VirtualKeyboardController::OnMaximizeModeEnded() {
-  if (!CommandLine::ForCurrentProcess()->HasSwitch(
-          keyboard::switches::kAutoVirtualKeyboard)) {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          keyboard::switches::kDisableSmartVirtualKeyboard)) {
     SetKeyboardEnabled(false);
   }
 }
 
 void VirtualKeyboardController::OnTouchscreenDeviceConfigurationChanged() {
   UpdateDevices();
 }
 
 void VirtualKeyboardController::OnKeyboardDeviceConfigurationChanged() {
   UpdateDevices();
@@ skipping 22 matching lines @@
     if (type == ui::InputDeviceType::INPUT_DEVICE_INTERNAL)
       has_internal_keyboard_ = true;
     if (type == ui::InputDeviceType::INPUT_DEVICE_EXTERNAL)
       has_external_keyboard_ = true;
   }
   // Update keyboard state.
   UpdateKeyboardEnabled();
 }
 
 void VirtualKeyboardController::UpdateKeyboardEnabled() {
-  if (!CommandLine::ForCurrentProcess()->HasSwitch(
-          keyboard::switches::kAutoVirtualKeyboard)) {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          keyboard::switches::kDisableSmartVirtualKeyboard)) {
     SetKeyboardEnabled(Shell::GetInstance()
                            ->maximize_mode_controller()
                            ->IsMaximizeModeWindowManagerEnabled());
     return;
   }
   SetKeyboardEnabled(!has_internal_keyboard_ && has_touchscreen_ &&
                      (!has_external_keyboard_ || ignore_external_keyboard_));
   ash::Shell::GetInstance()
       ->system_tray_notifier()
       ->NotifyVirtualKeyboardSuppressionChanged(!has_internal_keyboard_ &&
                                                 has_touchscreen_ &&
                                                 has_external_keyboard_);
 }
 
 void VirtualKeyboardController::SetKeyboardEnabled(bool enabled) {
   keyboard::SetTouchKeyboardEnabled(enabled);
   if (enabled) {
     Shell::GetInstance()->CreateKeyboard();
   } else {
     if (!keyboard::IsKeyboardEnabled())
       Shell::GetInstance()->DeactivateKeyboard();
   }
 }
 
 }  // namespace ash