Add ability to test parsing of bitcode records in Subzero.

Add ability to test parsing of bitcode records in Subzero.

Extends the NaCl bitcode munger so that the PNaClTranslator parser
can be applied to the defined sequence of record values.

BUG=None
R=jvoung@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2e7daeff480fa07a3bb8b3eeeedaec369a7521a7

[Karl, 2015-01-05 23:21:27]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-01-05 23:38:14]

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.cpp
File src/BitcodeMunge.cpp (right):

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.cpp#new...
src/BitcodeMunge.cpp:24: bool AddHeader = true;
const bool should be better

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h
File src/BitcodeMunge.h (right):

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h#newco...
src/BitcodeMunge.h:11: // bitcode mangler to do this.
mangler or munger?

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h#newco...
src/BitcodeMunge.h:19: namespace IceTest {
Add a blank line above?

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h#newco...
src/BitcodeMunge.h:21: // Class to run tests on subzero's bitcode parser. Runs a
subzero
Capitalize Subzero

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h#newco...
src/BitcodeMunge.h:22: // translation, using a (possibly) editted array of
bicode record
edited
bitcode

https://codereview.chromium.org/800883006/diff/20001/unittest/IceParseInstsTe...
File unittest/IceParseInstsTest.cpp (right):

https://codereview.chromium.org/800883006/diff/20001/unittest/IceParseInstsTe...
unittest/IceParseInstsTest.cpp:80: } // end of anonamous namespace.
anonymous
also, leave out the period for consistency?

[jvoung (off chromium), 2015-01-07 22:24:34]

https://codereview.chromium.org/800883006/diff/20001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/800883006/diff/20001/Makefile.standalone#newc...
Makefile.standalone:118: BitcodeMunge.cpp
Could this be under the unittest directory, and then include it always instead
of only under MINIMAL only?

[Karl, 2015-01-08 21:35:05]

https://codereview.chromium.org/800883006/diff/20001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/800883006/diff/20001/Makefile.standalone#newc...
Makefile.standalone:118: BitcodeMunge.cpp
On 2015/01/07 22:24:34, jvoung wrote:
> Could this be under the unittest directory, and then include it always instead
> of only under MINIMAL only?

Done. Added CL flag GenerateUnitTestMessages, and then used that to generate
simple (generic) error messages. This makes testing work in all scenarios.

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.cpp
File src/BitcodeMunge.cpp (right):

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.cpp#new...
src/BitcodeMunge.cpp:24: bool AddHeader = true;
On 2015/01/05 23:38:14, stichnot wrote:
> const bool should be better

Done.

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h
File src/BitcodeMunge.h (right):

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h#newco...
src/BitcodeMunge.h:11: // bitcode mangler to do this.
On 2015/01/05 23:38:14, stichnot wrote:
> mangler or munger?

mangler => munger

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h#newco...
src/BitcodeMunge.h:19: namespace IceTest {
On 2015/01/05 23:38:14, stichnot wrote:
> Add a blank line above?

Done.

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h#newco...
src/BitcodeMunge.h:21: // Class to run tests on subzero's bitcode parser. Runs a
subzero
On 2015/01/05 23:38:14, stichnot wrote:
> Capitalize Subzero

Done.

https://codereview.chromium.org/800883006/diff/20001/src/BitcodeMunge.h#newco...
src/BitcodeMunge.h:22: // translation, using a (possibly) editted array of
bicode record
On 2015/01/05 23:38:14, stichnot wrote:
> edited
> bitcode

Done.

https://codereview.chromium.org/800883006/diff/20001/unittest/IceParseInstsTe...
File unittest/IceParseInstsTest.cpp (right):

https://codereview.chromium.org/800883006/diff/20001/unittest/IceParseInstsTe...
unittest/IceParseInstsTest.cpp:80: } // end of anonamous namespace.
On 2015/01/05 23:38:14, stichnot wrote:
> anonymous
> also, leave out the period for consistency?

Done.

[Jim Stichnoth, 2015-01-08 23:45:25]

https://codereview.chromium.org/800883006/diff/40001/unittest/BitcodeMunge.h
File unittest/BitcodeMunge.h (right):

https://codereview.chromium.org/800883006/diff/40001/unittest/BitcodeMunge.h#...
unittest/BitcodeMunge.h:15: #ifndef SUBZERO_SRC_BITCODEMUNGE_H
Change this define to reflect the new file location.

https://codereview.chromium.org/800883006/diff/40001/unittest/BitcodeMunge.h#...
unittest/BitcodeMunge.h:22: // Class to run tests on subzero's bitcode parser.
Runs a Subzero
Capitalize Subzero

https://codereview.chromium.org/800883006/diff/40001/unittest/BitcodeMunge.h#...
unittest/BitcodeMunge.h:23: // translation, using (possibly) edited bicode
record values.  For
bitcode

[Karl, 2015-01-09 16:12:33]

https://codereview.chromium.org/800883006/diff/40001/unittest/BitcodeMunge.h
File unittest/BitcodeMunge.h (right):

https://codereview.chromium.org/800883006/diff/40001/unittest/BitcodeMunge.h#...
unittest/BitcodeMunge.h:15: #ifndef SUBZERO_SRC_BITCODEMUNGE_H
On 2015/01/08 23:45:25, stichnot wrote:
> Change this define to reflect the new file location.

Done.

https://codereview.chromium.org/800883006/diff/40001/unittest/BitcodeMunge.h#...
unittest/BitcodeMunge.h:22: // Class to run tests on subzero's bitcode parser.
Runs a Subzero
On 2015/01/08 23:45:25, stichnot wrote:
> Capitalize Subzero

Done.

https://codereview.chromium.org/800883006/diff/40001/unittest/BitcodeMunge.h#...
unittest/BitcodeMunge.h:23: // translation, using (possibly) edited bicode
record values.  For
On 2015/01/08 23:45:25, stichnot wrote:
> bitcode

Done.

[Jim Stichnoth, 2015-01-09 18:05:02]

lgtm

[jvoung (off chromium), 2015-01-09 18:19:57]

lgtm too

[Karl, 2015-01-09 21:04:25]

Committed patchset #4 (id:60001) manually as
2e7daeff480fa07a3bb8b3eeeedaec369a7521a7 (presubmit successful).