XFA: merge patch from CL 831903002, m_sTimeMap fixes

XFA: merge patch from CL 831903002, m_sTimeMap fixes

Get rid of fifteen copies of m_sTimeMap and their initializers.

m_sTimeMap is a global variable with a constructor and destructor, which
is not allowed. This change moves it to a function with a static pointer
so that it is constructed on demand and then leaked, thus avoiding
having startup and shutdown code.

This also fixes a worrisome bug caused by having m_sTimeMap defined in
a header file. Because m_sTimeMap was defined (and marked as static) in
a header file there were fifteen separate copies of it, one for each
source file which included the header file. This could easily lead to
bugs because a timer that was added from one source file would be
invisible to other source files.

Each instance of m_sTimeMap added four entries to the
dump-static-initializers.py report, for a total of sixty, so this fix
significantly cleans up that report.

BUG=441899
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/831903002

Committed: https://pdfium.googlesource.com/pdfium/+/b4649dc9c0f8f64c335d4ed61a82976f25e19a70

[brucedawson, 2015-01-05 21:26:21]

Committed patchset #1 (id:1) manually as
b4649dc9c0f8f64c335d4ed61a82976f25e19a70 (presubmit successful).

[Bo Xu, 2015-01-05 22:05:39]

bo_xu@foxitsoftware.com changed reviewers:
+ bo_xu@foxitsoftware.com

[Bo Xu, 2015-01-05 22:05:39]

https://codereview.chromium.org/800883004/diff/1/fpdfsdk/include/javascript/J...
File fpdfsdk/include/javascript/JS_Object.h (right):

https://codereview.chromium.org/800883004/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Object.h:201: m_sTimeMap.RemoveAt(m_nTimerID);
This one is not fixed?

[brucedawson, 2015-01-05 22:18:20]

https://codereview.chromium.org/800883004/diff/1/fpdfsdk/include/javascript/J...
File fpdfsdk/include/javascript/JS_Object.h (right):

https://codereview.chromium.org/800883004/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Object.h:201: m_sTimeMap.RemoveAt(m_nTimerID);
Good catch. I guess I'm merging over without enough double-checking. Fixing.