Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 800853007: cc: Move tiling raster tile iterator to be a tiling set queue class. (Closed)

Created:
5 years, 11 months ago by vmpstr
Modified:
5 years, 11 months ago
Reviewers:
danakj, reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move tiling raster tile iterator to be a tiling set queue class. This patch moves tiling raster tile iterator and makes it a private class of the tiling set raster queue. This reduces the public interface for accessing tiles. R=danakj, reveman Committed: https://crrev.com/dfcd77d6aa00197035c78693d9aca183e00e6884 Cr-Commit-Position: refs/heads/master@{#310446}

Patch Set 1 #

Total comments: 4

Patch Set 2 : undo rename #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+424 lines, -472 lines) Patch
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 4 chunks +23 lines, -50 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 3 chunks +7 lines, -138 lines 0 comments Download
M cc/resources/picture_layer_tiling_perftest.cc View 2 chunks +0 lines, -87 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 chunk +0 lines, -177 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 2 chunks +191 lines, -0 lines 0 comments Download
M cc/resources/tiling_set_raster_queue.h View 3 chunks +52 lines, -1 line 0 comments Download
M cc/resources/tiling_set_raster_queue.cc View 1 7 chunks +147 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
vmpstr
Please take a look. https://codereview.chromium.org/800853007/diff/1/cc/resources/picture_layer_tiling_perftest.cc File cc/resources/picture_layer_tiling_perftest.cc (left): https://codereview.chromium.org/800853007/diff/1/cc/resources/picture_layer_tiling_perftest.cc#oldcode242 cc/resources/picture_layer_tiling_perftest.cc:242: TEST_F(PictureLayerTilingPerfTest, TilingRasterTileIteratorConstruct) { These perftests ...
5 years, 11 months ago (2015-01-06 19:53:50 UTC) #1
danakj
LGTM https://codereview.chromium.org/800853007/diff/1/cc/resources/picture_layer_tiling.cc File cc/resources/picture_layer_tiling.cc (right): https://codereview.chromium.org/800853007/diff/1/cc/resources/picture_layer_tiling.cc#newcode792 cc/resources/picture_layer_tiling.cc:792: void PictureLayerTiling::UpdateTilePriority(Tile* tile) const { I liked the ...
5 years, 11 months ago (2015-01-07 20:05:31 UTC) #2
vmpstr
https://codereview.chromium.org/800853007/diff/1/cc/resources/picture_layer_tiling.cc File cc/resources/picture_layer_tiling.cc (right): https://codereview.chromium.org/800853007/diff/1/cc/resources/picture_layer_tiling.cc#newcode792 cc/resources/picture_layer_tiling.cc:792: void PictureLayerTiling::UpdateTilePriority(Tile* tile) const { On 2015/01/07 20:05:31, danakj ...
5 years, 11 months ago (2015-01-08 00:24:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800853007/40001
5 years, 11 months ago (2015-01-08 00:33:24 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-08 02:52:15 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 02:53:11 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dfcd77d6aa00197035c78693d9aca183e00e6884
Cr-Commit-Position: refs/heads/master@{#310446}

Powered by Google App Engine
This is Rietveld 408576698