Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 800853006: Reject connection attempts without prompt if target app doesn't handle the event anyway. (Closed)

Created:
6 years ago by Marijn Kruisselbrink
Modified:
5 years, 12 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject connection attempts without prompt if target app doesn't handle the event anyway. If a connection is not going to succeed, the user shouldn't be prompted to allow it. BUG=442497 Committed: https://crrev.com/1454e0ce0e335054490aa490a1eee9118d7fcf3a Cr-Commit-Position: refs/heads/master@{#309569}

Patch Set 1 #

Patch Set 2 : link to bug in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -33 lines) Patch
M chrome/browser/extensions/api/messaging/message_service.cc View 1 2 chunks +20 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 4 chunks +60 lines, -21 lines 0 comments Download
M chrome/common/extensions/api/extension.json View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/common/api/runtime.json View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Marijn Kruisselbrink
You seem to be about the only other extensions OWNER who isn't OOO...
6 years ago (2014-12-23 02:19:35 UTC) #5
Yoyo Zhou
LGTM. You can link to the crbug in the comment in message_service.cc.
6 years ago (2014-12-23 16:45:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800853006/80001
6 years ago (2014-12-23 17:17:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/17539)
6 years ago (2014-12-23 18:24:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800853006/80001
5 years, 12 months ago (2014-12-23 18:25:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 12 months ago (2014-12-23 18:58:52 UTC) #13
commit-bot: I haz the power
5 years, 12 months ago (2014-12-23 19:00:40 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1454e0ce0e335054490aa490a1eee9118d7fcf3a
Cr-Commit-Position: refs/heads/master@{#309569}

Powered by Google App Engine
This is Rietveld 408576698