Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 800833003: [turbofan] Correctify JSToBoolean lowering. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Correctify JSToBoolean lowering. Introduce a new AnyToBoolean simplified operator to handle the later lowering of boolean conversions. Previously we tried to hack that with the generic JSToBoolean, having its context set to zero, but that lead to various problems/bugs and did not handle all cases. TEST=cctest,unittests R=jarin@chromium.org Committed: https://crrev.com/9def087efcd844342c35f42628bac4ead49cac81 Cr-Commit-Position: refs/heads/master@{#25958}

Patch Set 1 #

Patch Set 2 : Add cctest for AnyToBoolean lowering. #

Patch Set 3 : Style fix #

Patch Set 4 : Improve simplified lowering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -264 lines) Patch
M src/compiler/js-typed-lowering.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +23 lines, -135 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.h View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 6 chunks +33 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 3 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 2 3 4 chunks +39 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +1 line, -42 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 2 3 3 chunks +42 lines, -4 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 3 2 chunks +110 lines, -71 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 2 3 5 chunks +40 lines, -4 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-02 14:15:50 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-02 14:18:49 UTC) #2
Jarin
lgtm
5 years, 11 months ago (2015-01-05 09:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800833003/60001
5 years, 11 months ago (2015-01-05 13:28:34 UTC) #5
Benedikt Meurer
Committed patchset #4 (id:60001) manually as 9def087efcd844342c35f42628bac4ead49cac81 (presubmit successful).
5 years, 11 months ago (2015-01-05 13:44:39 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 13:44:40 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9def087efcd844342c35f42628bac4ead49cac81
Cr-Commit-Position: refs/heads/master@{#25958}

Powered by Google App Engine
This is Rietveld 408576698