Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 8008026: Upstream: Set build target and evnvironment for Android (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by michaelbai
Modified:
4 years, 11 months ago
CC:
chromium-reviews, bulach
Visibility:
Public.

Description

Upstream: Set build target and evnvironment for Android BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102807

Patch Set 1 #

Total comments: 27

Patch Set 2 : Address the comments #

Total comments: 14

Patch Set 3 : Address comments #

Total comments: 18

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -0 lines) Patch
A build/all_android.gyp View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A build/android/envsetup.sh View 1 2 3 1 chunk +136 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 11 (0 generated)
michaelbai
Please help to review it
4 years, 11 months ago (2011-09-23 19:28:01 UTC) #1
John Grabowski
I generally like; some minor issues. Maybe now is the time to start documenting this ...
4 years, 11 months ago (2011-09-23 19:40:31 UTC) #2
Peter Beverloo
Looking good in general, thank you. http://codereview.chromium.org/8008026/diff/1/build/all_android.gyp File build/all_android.gyp (right): http://codereview.chromium.org/8008026/diff/1/build/all_android.gyp#newcode5 build/all_android.gyp:5: # This is ...
4 years, 11 months ago (2011-09-23 21:55:28 UTC) #3
michaelbai
PTAL http://codereview.chromium.org/8008026/diff/1/build/all_android.gyp File build/all_android.gyp (right): http://codereview.chromium.org/8008026/diff/1/build/all_android.gyp#newcode5 build/all_android.gyp:5: # This is all.gyp file for Android, currently ...
4 years, 11 months ago (2011-09-26 17:15:13 UTC) #4
jrg
LGTM Please get LGTM from Mento as well. http://codereview.chromium.org/8008026/diff/7001/build/all_android.gyp File build/all_android.gyp (right): http://codereview.chromium.org/8008026/diff/7001/build/all_android.gyp#newcode6 build/all_android.gyp:6: # ...
4 years, 11 months ago (2011-09-26 18:32:14 UTC) #5
Mark Mentovai
http://codereview.chromium.org/8008026/diff/7001/build/android/envsetup.sh File build/android/envsetup.sh (right): http://codereview.chromium.org/8008026/diff/7001/build/android/envsetup.sh#newcode2 build/android/envsetup.sh:2: # Copyright (c) 2011 The Chromium Authors. All rights ...
4 years, 11 months ago (2011-09-26 19:02:35 UTC) #6
michaelbai
PTAL http://codereview.chromium.org/8008026/diff/7001/build/all_android.gyp File build/all_android.gyp (right): http://codereview.chromium.org/8008026/diff/7001/build/all_android.gyp#newcode6 build/all_android.gyp:6: # prevent breakage in Android and other platform. ...
4 years, 11 months ago (2011-09-26 21:08:32 UTC) #7
Mark Mentovai
http://codereview.chromium.org/8008026/diff/8003/build/all_android.gyp File build/all_android.gyp (right): http://codereview.chromium.org/8008026/diff/8003/build/all_android.gyp#newcode2 build/all_android.gyp:2: No. Remove this blank line. http://codereview.chromium.org/8008026/diff/8003/build/all_android.gyp#newcode7 build/all_android.gyp:7: # and ...
4 years, 11 months ago (2011-09-26 21:14:31 UTC) #8
michaelbai
Thanks for the comments, PTAL. http://codereview.chromium.org/8008026/diff/8003/build/all_android.gyp File build/all_android.gyp (right): http://codereview.chromium.org/8008026/diff/8003/build/all_android.gyp#newcode2 build/all_android.gyp:2: On 2011/09/26 21:14:31, Mark ...
4 years, 11 months ago (2011-09-26 21:28:11 UTC) #9
Mark Mentovai
LGTM
4 years, 11 months ago (2011-09-26 21:29:39 UTC) #10
dunivanb
4 years, 11 months ago (2011-10-04 04:40:23 UTC) #11
is there a way to test this? can someone provide build instructions?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e15fb99