Issue 800783003: LevelDB: Removed global prefix from base namespace: "::base" -> "base"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 800783003: LevelDB: Removed global prefix from base namespace: "::base" -> "base" (Closed)

Created:
6 years ago by cmumford

Modified:
6 years ago

Reviewers:
jsbell

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

LevelDB: Removed global prefix from base namespace: "::base" -> "base" Committed: https://crrev.com/d72dc4d6f5790fb618a55ad38d8892c60054e9aa Cr-Commit-Position: refs/heads/master@{#308265}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -71 lines)			Patch
M	third_party/leveldatabase/chromium_logger.h	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	third_party/leveldatabase/env_chromium.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	third_party/leveldatabase/env_chromium.cc	View	1	16 chunks	+48 lines, -49 lines	0 comments	Download
M	third_party/leveldatabase/port/port_chromium.h	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	third_party/leveldatabase/port/port_chromium.cc	View	1	1 chunk	+6 lines, -8 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800783003/20001

6 years ago (2014-12-13 06:31:22 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-13 08:18:38 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/d72dc4d6f5790fb618a55ad38d8892c60054e9aa
Cr-Commit-Position: refs/heads/master@{#308265}