Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 800773002: Revert "Add image_diff from the chromium repo." (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
Reviewers:
ojan
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Revert "Add image_diff from the chromium repo." This reverts commit ac5097e515ce8237ead2c89bc61dc914cb75313b. Reason for revert: Breaks compile on the ASan bot (e.g., http://build.chromium.org/p/client.mojo/builders/Mojo%20Linux%20ASan/builds/95/steps/mojob%20build/logs/stdio). TBR=ojan Committed: https://chromium.googlesource.com/external/mojo/+/79d76b3da8f72ca3affaaaf2821b1d0bb212f522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1148 lines) Patch
M sky/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D sky/tools/imagediff/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/tools/imagediff/image_diff.cc View 1 chunk +0 lines, -449 lines 0 comments Download
D sky/tools/imagediff/image_diff_png.h View 1 chunk +0 lines, -35 lines 0 comments Download
D sky/tools/imagediff/image_diff_png.cc View 1 chunk +0 lines, -643 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blundell
6 years ago (2014-12-12 07:06:55 UTC) #1
blundell
6 years ago (2014-12-12 07:07:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
79d76b3da8f72ca3affaaaf2821b1d0bb212f522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698