Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 800723004: Report PasswordManager.OsPasswordStatus on a background thread with a delay. (Closed)

Created:
6 years ago by vasilii
Modified:
6 years ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, Will Harris, grt (UTC plus 2)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report PasswordManager.OsPasswordStatus on a background thread with a delay. The histogram was revived in https://codereview.chromium.org/772413004/ but caused jankiness on the UI thread. BUG=441428 Committed: https://crrev.com/08cd707154a8b1ca7869c5b410d98acb8a6ed3e7 Cr-Commit-Position: refs/heads/master@{#308128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/password_manager/password_store_factory.cc View 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vasilii
Hi Vaclav, please review.
6 years ago (2014-12-12 17:25:45 UTC) #2
vabr (Chromium)
lgtm
6 years ago (2014-12-12 17:34:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800723004/1
6 years ago (2014-12-12 17:39:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 18:41:27 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08cd707154a8b1ca7869c5b410d98acb8a6ed3e7 Cr-Commit-Position: refs/heads/master@{#308128}
6 years ago (2014-12-12 18:42:11 UTC) #7
grt (UTC plus 2)
This change introduced a DCHECK because CheckBlankPassword accesses the browser process's local_state() off the main ...
6 years ago (2014-12-16 18:21:16 UTC) #8
grt (UTC plus 2)
6 years ago (2014-12-16 18:28:45 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/802923003/ by grt@chromium.org.

The reason for reverting is: Reverting because DCHECK is hit 40s after startup..

Powered by Google App Engine
This is Rietveld 408576698