Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: pkg/analysis_server/test/services/completion/completion_computer_test.dart

Issue 800723002: Allow completions to wait for analysis without requiring a busy wait loop. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/completion_computer_test.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_computer_test.dart b/pkg/analysis_server/test/services/completion/completion_computer_test.dart
index ac21d892ccb12bbb67afd076e340605348b95416..217a11d6a145b57c7367ae5955d254d83a8e1f2c 100644
--- a/pkg/analysis_server/test/services/completion/completion_computer_test.dart
+++ b/pkg/analysis_server/test/services/completion/completion_computer_test.dart
@@ -50,6 +50,7 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {
MockCompletionComputer computer2;
CompletionSuggestion suggestion1;
CompletionSuggestion suggestion2;
+ bool _continuePerformingAnalysis = true;
void resolveLibrary() {
context.resolveCompilationUnit(
@@ -81,6 +82,12 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {
2,
false,
false);
+ new Future(_performAnalysis);
+ }
+
+ @override
+ void tearDown() {
+ _continuePerformingAnalysis = false;
}
test_compute_fastAndFull() {
@@ -148,6 +155,14 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {
expect(done, isTrue);
});
}
+
+ void _performAnalysis() {
+ if (!_continuePerformingAnalysis) {
+ return;
+ }
+ context.performAnalysisTask();
+ new Future(_performAnalysis);
+ }
}
class MockCompletionComputer extends DartCompletionComputer {

Powered by Google App Engine
This is Rietveld 408576698