Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 800713005: Roll src/buildtools ea47835:451dcd0 (Closed)

Created:
5 years, 12 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
CC:
chromium-reviews, earthdok, Alexander Potapenko, kjellander_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/buildtools ea47835:451dcd0 Summary of changes available at: https://chromium.googlesource.com/chromium/buildtools/+log/ea47835..451dcd0 BUG=443987 Committed: https://crrev.com/37d1e1f7f34901a7f643494feb1c18cf6e48a6ae Cr-Commit-Position: refs/heads/master@{#310578}

Patch Set 1 #

Patch Set 2 : Licence whitelist in new location. #

Patch Set 3 : Update hash... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/checklicenses/checklicenses.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Michael Achenbach
PTAL
5 years, 12 months ago (2014-12-23 08:51:28 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 12 months ago (2014-12-23 08:52:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800713005/1
5 years, 12 months ago (2014-12-23 08:58:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/33351)
5 years, 12 months ago (2014-12-23 09:09:53 UTC) #7
Michael Achenbach
We'll be waiting with this until the licensing issue is resolved...
5 years, 12 months ago (2014-12-23 09:22:59 UTC) #8
Michael Achenbach
PTAL Pawel for the licence check. The roll hash will be updated to https://codereview.chromium.org/840003002/ once ...
5 years, 11 months ago (2015-01-08 12:55:35 UTC) #10
Paweł Hajdan Jr.
LGTM
5 years, 11 months ago (2015-01-08 13:08:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800713005/40001
5 years, 11 months ago (2015-01-08 13:09:44 UTC) #13
Michael Achenbach
CC kjellander
5 years, 11 months ago (2015-01-08 13:10:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/21130)
5 years, 11 months ago (2015-01-08 14:43:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800713005/40001
5 years, 11 months ago (2015-01-08 19:37:22 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-08 20:13:18 UTC) #19
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 20:14:01 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/37d1e1f7f34901a7f643494feb1c18cf6e48a6ae
Cr-Commit-Position: refs/heads/master@{#310578}

Powered by Google App Engine
This is Rietveld 408576698