- Implement Isolate.kill.

runtime/vm/code_generator.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
@@ skipping 1174 matching lines @@
   }
 
   uword interrupt_bits = isolate->GetAndClearInterrupts();
   if ((interrupt_bits & Isolate::kStoreBufferInterrupt) != 0) {
     if (FLAG_verbose_gc) {
       OS::PrintErr("Scavenge scheduled by store buffer overflow.\n");
     }
     isolate->heap()->CollectGarbage(Heap::kNew);
   }
   if ((interrupt_bits & Isolate::kMessageInterrupt) != 0) {
-    isolate->message_handler()->HandleOOBMessages();
+    bool ok = isolate->message_handler()->HandleOOBMessages();
+    if (!ok) {
+      const String& msg = String::Handle(String::New("unwind"));

[siva, 2014/12/13 00:24:05]

why not "isolate terminated" instead of "unwind" string.

[Ivan Posva, 2014/12/13 00:36:47]

Done and added a comment.

+      const UnwindError& error = UnwindError::Handle(UnwindError::New(msg));
+      Exceptions::PropagateError(error);

[Lasse Reichstein Nielsen, 2014/12/13 02:04:46]

If an UnwindError terminates the isolate without running any further user code,
then this looks fine. It shouldn't trigger catch or finally blocks.

[Ivan Posva, 2014/12/15 22:25:59]

PropagateError does propagate the error to the next C frame on the stack so that
native  C/C++ code can properly release resources before propagating the error
further. This is the same mechanism that is used to propagate compilation errors
(AKA LanguageError).

+      UNREACHABLE();
+    }
   }
   if ((interrupt_bits & Isolate::kApiInterrupt) != 0) {
     // Signal isolate interrupt event.
     Debugger::SignalIsolateInterrupted();
 
     Dart_IsolateInterruptCallback callback = isolate->InterruptCallback();
     if (callback) {
       if ((*callback)()) {
         return;
       } else {
@@ skipping 439 matching lines @@
   field.RecordStore(value);
 }
 
 
 DEFINE_RUNTIME_ENTRY(InitStaticField, 1) {
   const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
   field.EvaluateInitializer();
 }
 
 }  // namespace dart