Issue 800663003: Cleanup: More override fixes - include version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 800663003: Cleanup: More override fixes - include version. (Closed)

Created:
6 years ago by tfarina

Modified:
6 years ago

Reviewers:
reed1

CC:
reviews_skia.org, Nico

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -41 lines)			Patch
	M	include/pdf/SkPDFDevice.h	View		1 chunk	+37 lines, -37 lines	0 comments	Download
	M	include/views/SkWidget.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

tfarina

Reed, could you rubber stamp this? So the presubmit does not block me. Thanks!

6 years ago (2014-12-20 19:04:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800663003/1

6 years ago (2014-12-21 18:17:43 UTC) #3

commit-bot: I haz the power

6 years ago (2014-12-21 18:27:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fa4f6cba2f9260cec345ec51fb3687c20c50fa61