Source/core/editing/DOMSelection.h - Issue 800633004: ShadowRoot's getSelection().getRangeAt(0) returns an incorrect Range object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/DOMSelection.h

Issue 800633004: ShadowRoot's getSelection().getRangeAt(0) returns an incorrect Range object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/shadow/getRangeAt-end-of-text-node.html ('K') | « LayoutTests/editing/shadow/getRangeAt-end-of-text-node-expected.txt ('k') | Source/core/editing/DOMSelection.cpp » ('j') | Source/core/editing/DOMSelection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/DOMSelection.h

diff --git a/Source/core/editing/DOMSelection.h b/Source/core/editing/DOMSelection.h

index 0a02168ae30cd71c1a9ecf2dd44956c1a5feda14..7912bc8b00edbfd6da339beb06ef81ab8e7b9783 100644

--- a/Source/core/editing/DOMSelection.h

+++ b/Source/core/editing/DOMSelection.h

@@ -103,7 +103,9 @@ private:

// Convenience method for accessors, does not check m_frame present.

const VisibleSelection& visibleSelection() const;

+ bool isInShadowTree() const;

+ Position shadowAdjustedPosition(const Position&) const;

Node* shadowAdjustedNode(const Position&) const;

int shadowAdjustedOffset(const Position&) const;