LayoutTests/editing/shadow/getRangeAt-end-of-text-node.html - Issue 800633004: ShadowRoot's getSelection().getRangeAt(0) returns an incorrect Range object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/shadow/getRangeAt-end-of-text-node.html

Issue 800633004: ShadowRoot's getSelection().getRangeAt(0) returns an incorrect Range object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix test failures Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <div id="shadowHost"></div>

	5 <script>

	6 (function () {

	7 var shadowRoot = shadowHost.createShadowRoot();

	8 shadowRoot.innerHTML = '<div id="editable" contenteditable>Test</div>';

	9 var textNode = shadowRoot.querySelector("#editable").firstChild;

	10 var selection = shadowRoot.getSelection();

	11 selection.collapse(textNode, textNode.textContent.length);

	12 test(function () {

	13 var range = selection.getRangeAt(0);

	14 assert_equals(range.startContainer, textNode);

	15 assert_equals(range.startOffset, textNode.textContent.length);

	16 assert_true(range.collapsed);

	17 }, "collapsed");

	18

	19 selection.collapse(textNode, 0);

	20 selection.extend(textNode, 2);

	21 test(function () {

	22 var range = selection.getRangeAt(0);

	23 assert_equals(range.startContainer, textNode);

	24 assert_equals(range.startOffset, 0);

	25 assert_equals(range.endContainer, textNode);

	26 assert_equals(range.endOffset, 2);

	27 assert_false(range.collapsed);

	28 }, "range");

	29

	30 test(function () {

	31 assert_not_equals(window.getSelection().getRangeAt(0).anchorNode, textNo de);

	32 }, "Nodes in Shadow should not be exposed to window.getSelection()");

	33 })();

	34 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/editing/DOMSelection.cpp » ('j') | Source/core/editing/DOMSelection.cpp » ('J')