Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 800613009: Convert scroll offsets to use SyncedProperty. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android WebView tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_impl.h ('k') | cc/trees/property_tree_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index a50b2ff8103b4c3e1f04f6d367d93d3c89c5740c..76f27508c6ed6a19cfb1210adf1d7fd3d985a1e1 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -50,11 +50,11 @@ class LayerScrollOffsetDelegateProxy : public LayerImpl::ScrollOffsetDelegate {
}
// LayerScrollOffsetDelegate implementation.
- void SetTotalScrollOffset(const gfx::ScrollOffset& new_offset) override {
+ void SetCurrentScrollOffset(const gfx::ScrollOffset& new_offset) override {
last_set_scroll_offset_ = new_offset;
}
- gfx::ScrollOffset GetTotalScrollOffset() override {
+ gfx::ScrollOffset GetCurrentScrollOffset() override {
return layer_tree_impl_->GetDelegatedScrollOffset(layer_);
}
@@ -154,10 +154,10 @@ gfx::ScrollOffset LayerTreeImpl::TotalScrollOffset() const {
gfx::ScrollOffset offset;
if (inner_viewport_scroll_layer_)
- offset += inner_viewport_scroll_layer_->TotalScrollOffset();
+ offset += inner_viewport_scroll_layer_->CurrentScrollOffset();
if (outer_viewport_scroll_layer_)
- offset += outer_viewport_scroll_layer_->TotalScrollOffset();
+ offset += outer_viewport_scroll_layer_->CurrentScrollOffset();
return offset;
}
@@ -173,15 +173,6 @@ gfx::ScrollOffset LayerTreeImpl::TotalMaxScrollOffset() const {
return offset;
}
-gfx::Vector2dF LayerTreeImpl::TotalScrollDelta() const {
- DCHECK(inner_viewport_scroll_layer_);
- gfx::Vector2dF delta = inner_viewport_scroll_layer_->ScrollDelta();
-
- if (outer_viewport_scroll_layer_)
- delta += outer_viewport_scroll_layer_->ScrollDelta();
-
- return delta;
-}
scoped_ptr<LayerImpl> LayerTreeImpl::DetachLayerTree() {
// Clear all data structures that have direct references to the layer tree.
@@ -468,19 +459,6 @@ void LayerTreeImpl::ApplySentScrollAndScaleDeltasFromAbortedCommit() {
root_layer(), base::Bind(&ApplySentScrollDeltasFromAbortedCommitTo));
}
-static void ApplyScrollDeltasSinceBeginMainFrameTo(LayerImpl* layer) {
- layer->ApplyScrollDeltasSinceBeginMainFrame();
-}
-
-void LayerTreeImpl::ApplyScrollDeltasSinceBeginMainFrame() {
- DCHECK(IsPendingTree());
- if (!root_layer())
- return;
-
- LayerTreeHostCommon::CallFunctionForSubtree(
- root_layer(), base::Bind(&ApplyScrollDeltasSinceBeginMainFrameTo));
-}
-
void LayerTreeImpl::SetViewportLayersFromIds(
int overscroll_elasticity_layer_id,
int page_scale_layer_id,
@@ -997,6 +975,11 @@ void LayerTreeImpl::SetRootLayerScrollOffsetDelegate(
}
if (inner_viewport_scroll_layer_)
+ inner_viewport_scroll_layer_->RefreshFromScrollDelegate();
+ if (outer_viewport_scroll_layer_)
+ outer_viewport_scroll_layer_->RefreshFromScrollDelegate();
+
+ if (inner_viewport_scroll_layer_)
UpdateScrollOffsetDelegate();
}
}
@@ -1004,10 +987,10 @@ void LayerTreeImpl::SetRootLayerScrollOffsetDelegate(
void LayerTreeImpl::OnRootLayerDelegatedScrollOffsetChanged() {
DCHECK(root_layer_scroll_offset_delegate_);
if (inner_viewport_scroll_layer_) {
- inner_viewport_scroll_layer_->DidScroll();
+ inner_viewport_scroll_layer_->RefreshFromScrollDelegate();
}
if (outer_viewport_scroll_layer_) {
- outer_viewport_scroll_layer_->DidScroll();
+ outer_viewport_scroll_layer_->RefreshFromScrollDelegate();
}
}
« no previous file with comments | « cc/trees/layer_tree_impl.h ('k') | cc/trees/property_tree_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698