Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: cc/trees/layer_tree_host_common.cc

Issue 800613009: Convert scroll offsets to use SyncedProperty. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host_common.h" 5 #include "cc/trees/layer_tree_host_common.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/debug/trace_event.h" 9 #include "base/debug/trace_event.h"
10 #include "cc/base/math_util.h" 10 #include "cc/base/math_util.h"
(...skipping 28 matching lines...) Expand all
39 static void SortLayers(LayerImplList::iterator first, 39 static void SortLayers(LayerImplList::iterator first,
40 LayerImplList::iterator end, 40 LayerImplList::iterator end,
41 LayerSorter* layer_sorter) { 41 LayerSorter* layer_sorter) {
42 DCHECK(layer_sorter); 42 DCHECK(layer_sorter);
43 TRACE_EVENT0("cc", "LayerTreeHostCommon::SortLayers"); 43 TRACE_EVENT0("cc", "LayerTreeHostCommon::SortLayers");
44 layer_sorter->Sort(first, end); 44 layer_sorter->Sort(first, end);
45 } 45 }
46 46
47 template <typename LayerType> 47 template <typename LayerType>
48 static gfx::Vector2dF GetEffectiveScrollDelta(LayerType* layer) { 48 static gfx::Vector2dF GetEffectiveScrollDelta(LayerType* layer) {
49 gfx::Vector2dF scroll_delta = layer->ScrollDelta(); 49 gfx::ScrollOffset scroll_delta = layer->ScrollDelta();
50 // The scroll parent's scroll delta is the amount we've scrolled on the 50 // The scroll parent's scroll delta is the amount we've scrolled on the
51 // compositor thread since the commit for this layer tree's source frame. 51 // compositor thread since the commit for this layer tree's source frame.
52 // we last reported to the main thread. I.e., it's the discrepancy between 52 // we last reported to the main thread. I.e., it's the discrepancy between
53 // a scroll parent's scroll delta and offset, so we must add it here. 53 // a scroll parent's scroll delta and offset, so we must add it here.
54 if (layer->scroll_parent()) 54 if (layer->scroll_parent())
55 scroll_delta += layer->scroll_parent()->ScrollDelta(); 55 scroll_delta += layer->scroll_parent()->ScrollDelta();
56 return scroll_delta; 56 return gfx::Vector2dF(scroll_delta.x(), scroll_delta.y());
57 } 57 }
58 58
59 template <typename LayerType> 59 template <typename LayerType>
60 static gfx::ScrollOffset GetEffectiveTotalScrollOffset(LayerType* layer) { 60 static gfx::ScrollOffset GetEffectiveCurrentScrollOffset(LayerType* layer) {
61 gfx::ScrollOffset offset = layer->TotalScrollOffset(); 61 gfx::ScrollOffset offset = layer->CurrentScrollOffset();
62 // The scroll parent's total scroll offset (scroll offset + scroll delta) 62 // The scroll parent's total scroll offset (scroll offset + scroll delta)
63 // can't be used because its scroll offset has already been applied to the 63 // can't be used because its scroll offset has already been applied to the
64 // scroll children's positions by the main thread layer positioning code. 64 // scroll children's positions by the main thread layer positioning code.
65 if (layer->scroll_parent()) 65 if (layer->scroll_parent())
66 offset += gfx::ScrollOffset(layer->scroll_parent()->ScrollDelta()); 66 offset += gfx::ScrollOffset(layer->scroll_parent()->ScrollDelta());
67 return offset; 67 return offset;
68 } 68 }
69 69
70 inline gfx::Rect CalculateVisibleRectWithCachedLayerRect( 70 inline gfx::Rect CalculateVisibleRectWithCachedLayerRect(
71 const gfx::Rect& target_surface_rect, 71 const gfx::Rect& target_surface_rect,
(...skipping 1587 matching lines...) Expand 10 before | Expand all | Expand 10 after
1659 1659
1660 bool animating_transform_to_target = layer->TransformIsAnimating(); 1660 bool animating_transform_to_target = layer->TransformIsAnimating();
1661 bool animating_transform_to_screen = animating_transform_to_target; 1661 bool animating_transform_to_screen = animating_transform_to_target;
1662 if (layer->parent()) { 1662 if (layer->parent()) {
1663 animating_transform_to_target |= 1663 animating_transform_to_target |=
1664 layer->parent()->draw_transform_is_animating(); 1664 layer->parent()->draw_transform_is_animating();
1665 animating_transform_to_screen |= 1665 animating_transform_to_screen |=
1666 layer->parent()->screen_space_transform_is_animating(); 1666 layer->parent()->screen_space_transform_is_animating();
1667 } 1667 }
1668 gfx::Point3F transform_origin = layer->transform_origin(); 1668 gfx::Point3F transform_origin = layer->transform_origin();
1669 gfx::ScrollOffset scroll_offset = GetEffectiveTotalScrollOffset(layer); 1669 gfx::ScrollOffset scroll_offset = GetEffectiveCurrentScrollOffset(layer);
1670 gfx::PointF position = 1670 gfx::PointF position =
1671 layer->position() - ScrollOffsetToVector2dF(scroll_offset); 1671 layer->position() - ScrollOffsetToVector2dF(scroll_offset);
1672 gfx::Transform combined_transform = data_from_ancestor.parent_matrix; 1672 gfx::Transform combined_transform = data_from_ancestor.parent_matrix;
1673 if (!layer->transform().IsIdentity()) { 1673 if (!layer->transform().IsIdentity()) {
1674 // LT = Tr[origin] * Tr[origin2transformOrigin] 1674 // LT = Tr[origin] * Tr[origin2transformOrigin]
1675 combined_transform.Translate3d(position.x() + transform_origin.x(), 1675 combined_transform.Translate3d(position.x() + transform_origin.x(),
1676 position.y() + transform_origin.y(), 1676 position.y() + transform_origin.y(),
1677 transform_origin.z()); 1677 transform_origin.z());
1678 // LT = Tr[origin] * Tr[origin2origin] * M[layer] 1678 // LT = Tr[origin] * Tr[origin2origin] * M[layer]
1679 combined_transform.PreconcatTransform(layer->transform()); 1679 combined_transform.PreconcatTransform(layer->transform());
(...skipping 890 matching lines...) Expand 10 before | Expand all | Expand 10 after
2570 inputs->current_render_surface_layer_list_id); 2570 inputs->current_render_surface_layer_list_id);
2571 2571
2572 // The dummy layer list should not have been used. 2572 // The dummy layer list should not have been used.
2573 DCHECK_EQ(0u, dummy_layer_list.size()); 2573 DCHECK_EQ(0u, dummy_layer_list.size());
2574 // A root layer render_surface should always exist after 2574 // A root layer render_surface should always exist after
2575 // CalculateDrawProperties. 2575 // CalculateDrawProperties.
2576 DCHECK(inputs->root_layer->render_surface()); 2576 DCHECK(inputs->root_layer->render_surface());
2577 } 2577 }
2578 2578
2579 } // namespace cc 2579 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698