Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 800613002: Scoping auth tokens by app (Closed)

Created:
6 years ago by Charlie
Modified:
6 years ago
Reviewers:
rkc
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scoping auth tokens by app BUG=431868 Committed: https://crrev.com/dce8e6459a6dc7361dcffd9933250bbd02176934 Cr-Commit-Position: refs/heads/master@{#308043}

Patch Set 1 #

Patch Set 2 : Removing unnecessary checks for empty app ID #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M chrome/browser/extensions/api/copresence/copresence_api.h View 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/copresence/copresence_api.cc View 1 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rkc
lgtm
6 years ago (2014-12-12 00:20:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800613002/20001
6 years ago (2014-12-12 00:35:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 03:29:48 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 03:31:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dce8e6459a6dc7361dcffd9933250bbd02176934
Cr-Commit-Position: refs/heads/master@{#308043}

Powered by Google App Engine
This is Rietveld 408576698