Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 800573002: Add parameter to specify gyp dir to gyp_to_android. (Closed)

Created:
6 years ago by scroggo
Modified:
6 years ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add parameter to specify gyp dir to gyp_to_android. NOTRY=true NOTREECHECKS=True BUG=skia:3233 Committed: https://skia.googlesource.com/skia/+/60936c732b1d21940a21a95f5757ae24c666877b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M platform_tools/android/bin/gyp_to_android.py View 4 chunks +17 lines, -10 lines 0 comments Download
M platform_tools/android/gyp_gen/android_framework_gyp.py View 2 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
scroggo
6 years ago (2014-12-11 20:31:28 UTC) #2
borenet
LGTM
6 years ago (2014-12-11 20:34:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800573002/1
6 years ago (2014-12-11 20:36:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800573002/1
6 years ago (2014-12-11 20:39:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800573002/1
6 years ago (2014-12-11 21:05:06 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-11 21:05:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/60936c732b1d21940a21a95f5757ae24c666877b

Powered by Google App Engine
This is Rietveld 408576698