toolchain_build/toolchain_build_pnacl.py - Issue 800553003: Update PNaCl to LLVM/Clang/Libcxx 223109 (nacl-change)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: toolchain_build/toolchain_build_pnacl.py

Issue 800553003: Update PNaCl to LLVM/Clang/Libcxx 223109 (nacl-change) (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: rebase again Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pnacl/driver/pnacl-ld.py ('K') | « toolchain_build/pnacl_targetlibs.py ('k') | tools/toolchain_tester/known_failures_pnacl.txt » ('j') | tools/toolchain_tester/known_failures_pnacl.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: toolchain_build/toolchain_build_pnacl.py

diff --git a/toolchain_build/toolchain_build_pnacl.py b/toolchain_build/toolchain_build_pnacl.py

index d211309c9559d28adbc3c414f73f385a84fc0111..ff8d836f475ca7bd4eb01fc91b7f1ce82f5c7e56 100755

--- a/toolchain_build/toolchain_build_pnacl.py

+++ b/toolchain_build/toolchain_build_pnacl.py

@@ -225,11 +225,6 @@ def ConfigureHostArchFlags(host, extra_cflags, options, extra_configure=None):

configure_args.extend(['CFLAGS=' + ' '.join(extra_cflags),

'CXXFLAGS=' + ' '.join(extra_cflags)])

else:

- # TODO(jvoung): Remove this after merging LLVM to be cleaner

- # w.r.t. -Winconsistent-missing-override.

- # https://code.google.com/p/nativeclient/issues/detail?id=4026

- if not options.gcc:

- extra_cflags.append('-Wno-inconsistent-missing-override')

configure_args.extend(

['CFLAGS=' + ' '.join(extra_cflags),

'LDFLAGS=-L%(' + GSDJoin('abs_libcxx', host) + ')s/lib',

« pnacl/driver/pnacl-ld.py ('K') | « toolchain_build/pnacl_targetlibs.py ('k') | tools/toolchain_tester/known_failures_pnacl.txt » ('j') | tools/toolchain_tester/known_failures_pnacl.txt » ('J')