Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 800543005: Revert of Implemented explicit resizing from guestview. (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, extensions-reviews_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implemented explicit resizing from guestview. (patchset #6 id:120001 of https://codereview.chromium.org/847893002/) Reason for revert: Broke out of process PDF. Original issue's description: > Implemented explicit resizing from guestview. > > A guest can now be explicitly resized (in addition to autosizing) from guest_view.js, using the new |setSize| function. This new function combines autosizing and normal resizing, as described in: https://docs.google.com/document/d/1EJfmJSK0JJsxKptSRhepnsOOwvXJNv5nnJ1pZdjGDRQ > > BUG=434226 > > Committed: https://crrev.com/681a4fc1d1ac77a17c69ba23fa6710a0e3aa206f > Cr-Commit-Position: refs/heads/master@{#311286} TBR=paulmeyer@chromium.org NOTREECHECKS=true NOTRY=true BUG=434226 Committed: https://crrev.com/78a50272ee606506c156aa4b34f4f03c5a4f654a Cr-Commit-Position: refs/heads/master@{#311379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -185 lines) Patch
M chrome/renderer/resources/extensions/extension_options.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 2 chunks +5 lines, -8 lines 0 comments Download
M extensions/browser/api/guest_view/guest_view_internal_api.h View 1 chunk +5 lines, -5 lines 0 comments Download
M extensions/browser/api/guest_view/guest_view_internal_api.cc View 1 chunk +12 lines, -25 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 5 chunks +8 lines, -23 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 6 chunks +28 lines, -62 lines 0 comments Download
M extensions/common/api/guest_view_internal.json View 3 chunks +7 lines, -14 lines 0 comments Download
M extensions/common/guest_view/guest_view_constants.h View 2 chunks +1 line, -5 lines 0 comments Download
M extensions/common/guest_view/guest_view_constants.cc View 2 chunks +1 line, -5 lines 0 comments Download
M extensions/renderer/resources/guest_view/guest_view.js View 3 chunks +15 lines, -15 lines 0 comments Download
M extensions/renderer/resources/guest_view/guest_view_container.js View 2 chunks +6 lines, -12 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_attributes.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Fady Samuel
Created Revert of Implemented explicit resizing from guestview.
5 years, 11 months ago (2015-01-14 00:53:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800543005/1
5 years, 11 months ago (2015-01-14 00:55:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 01:00:33 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 01:03:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78a50272ee606506c156aa4b34f4f03c5a4f654a
Cr-Commit-Position: refs/heads/master@{#311379}

Powered by Google App Engine
This is Rietveld 408576698