Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: mojo/public/dart/src/codec.dart

Issue 800523004: Dart: Simplifies the handle watcher. Various cleanups and bugfixes. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/dart/src/codec.dart
diff --git a/mojo/public/dart/src/codec.dart b/mojo/public/dart/src/codec.dart
index 5d017367e4afb3e676ce027519afe946869c6658..e51295837ea4c987856e392b23ab65066c7993a9 100644
--- a/mojo/public/dart/src/codec.dart
+++ b/mojo/public/dart/src/codec.dart
@@ -470,16 +470,20 @@ class Message {
Message(this.buffer, this.handles);
- int getHeaderNumBytes() => buffer.getUint32(kStructHeaderNumBytesOffset);
- int getHeaderNumFields() => buffer.getUint32(kStructHeaderNumFieldsOffset);
- int getName() => buffer.getUint32(kMessageNameOffset);
- int getFlags() => buffer.getUint32(kMessageFlagsOffset);
- bool isResponse() => (getFlags() & kMessageIsResponse) != 0;
- bool expectsResponse() => (getFlags() & kMessageExpectsResponse) != 0;
-
- void setRequestID(int id) {
- buffer.setUint64(kMessageRequestIDOffset, id);
- }
+ int get headerNumBytes =>
+ buffer.getUint32(kStructHeaderNumBytesOffset, Endianness.LITTLE_ENDIAN);
+ int get headerNumFields =>
+ buffer.getUint32(kStructHeaderNumFieldsOffset, Endianness.LITTLE_ENDIAN);
+ int get name =>
+ buffer.getUint32(kMessageNameOffset, Endianness.LITTLE_ENDIAN);
+ int get flags =>
+ buffer.getUint32(kMessageFlagsOffset, Endianness.LITTLE_ENDIAN);
+ int get requestID =>
+ buffer.getUint64(kMessageRequestIDOffset, Endianness.LITTLE_ENDIAN);
+ set requestID(int id) =>
+ buffer.setUint64(kMessageRequestIDOffset, id, Endianness.LITTLE_ENDIAN);
+ bool get isResponse => (flags & kMessageIsResponse) != 0;
+ bool get expectsResponse => (flags & kMessageExpectsResponse) != 0;
}

Powered by Google App Engine
This is Rietveld 408576698