Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: mojo/dart/test/ping_pong_test.dart

Issue 800523004: Dart: Simplifies the handle watcher. Various cleanups and bugfixes. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/test/ping_pong_test.dart
diff --git a/mojo/dart/test/ping_pong_test.dart b/mojo/dart/test/ping_pong_test.dart
index f821aa24c0ec6895e3fe390fc19a2ba4b29d540e..20b402cb4b28a32bff160e337b8504e17c01631e 100644
--- a/mojo/dart/test/ping_pong_test.dart
+++ b/mojo/dart/test/ping_pong_test.dart
@@ -36,19 +36,20 @@ void expectStringFromEndpoint(
void pipeTestIsolate(core.MojoMessagePipeEndpoint endpoint) {
var handle = new core.MojoHandle(endpoint.handle);
- handle.listen((int signal) {
- if (core.MojoHandleSignals.isReadWrite(signal)) {
+ handle.listen((List<int> event) {
+ var mojoSignals = new core.MojoHandleSignals(event[1]);
+ if (mojoSignals.isReadWrite) {
throw 'We should only be reading or writing, not both.';
- } else if (core.MojoHandleSignals.isReadable(signal)) {
+ } else if (mojoSignals.isReadable) {
expectStringFromEndpoint("Ping", endpoint);
handle.enableWriteEvents();
- } else if (core.MojoHandleSignals.isWritable(signal)) {
+ } else if (mojoSignals.isWritable) {
endpoint.write(byteDataOfString("Pong"));
- handle.disableWriteEvents();
- } else if (core.MojoHandleSignals.isNone(signal)) {
+ handle.enableReadEvents();
+ } else if (mojoSignals.isPeerClosed) {
handle.close();
} else {
- throw 'Unexpected signal.';
+ throw 'Unexpected event.';
}
});
}
@@ -58,21 +59,22 @@ main() {
var endpoint = pipe.endpoints[0];
var handle = new core.MojoHandle(endpoint.handle);
Isolate.spawn(pipeTestIsolate, pipe.endpoints[1]).then((_) {
- handle.enableWriteEvents();
- handle.listen((int signal) {
- if (core.MojoHandleSignals.isReadWrite(signal)) {
+ handle.listen((List<int> event) {
+ var mojoSignals = new core.MojoHandleSignals(event[1]);
+ if (mojoSignals.isReadWrite) {
throw 'We should only be reading or writing, not both.';
- } else if (core.MojoHandleSignals.isReadable(signal)) {
+ } else if (mojoSignals.isReadable) {
expectStringFromEndpoint("Pong", endpoint);
handle.close();
- } else if (core.MojoHandleSignals.isWritable(signal)) {
+ } else if (mojoSignals.isWritable) {
endpoint.write(byteDataOfString("Ping"));
- handle.disableWriteEvents();
- } else if (core.MojoHandleSignals.isNone(signal)) {
+ handle.enableReadEvents();
+ } else if (mojoSignals.isPeerClosed) {
throw 'This end should close first.';
} else {
- throw 'Unexpected signal.';
+ throw 'Unexpected event.';
}
});
+ handle.enableWriteEvents();
});
}

Powered by Google App Engine
This is Rietveld 408576698