mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl - Issue 800523004: Dart: Simplifies the handle watcher. Various cleanups and bugfixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl

Issue 800523004: Dart: Simplifies the handle watcher. Various cleanups and bugfixes. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: cleanup Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl ('k') | mojo/public/tools/bindings/generators/mojom_dart_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl b/mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl

index 6e18dc89f36b683b70f7703f681d7540ce77d805..8b2fa42c2268efd68a31f2412082dae0512ac76e 100644

--- a/mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl

@@ -57,7 +57,7 @@ class {{struct.name}} {

{%- if byte.packed_fields|length > 1 %}

packed = 0;

{%- for packed_field in byte.packed_fields %}

- packed |= (val.{{packed_field.field.name}} & 1) << {{packed_field.bit}};

+ packed |= ((val.{{packed_field.field.name}} ? 1 : 0) & 1) << {{packed_field.bit}};

{%- endfor %}

encoder.writeUint8(packed);

{%- else %}