Dart: Simplifies the handle watcher. Various cleanups and bugfixes.

mojo/public/dart/src/codec.dart

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(zra): Rewrite MojoDecoder and MojoEncoder using Dart idioms, and make
 // corresponding changes to the bindings generation script.
 
 part of bindings;
 
 const int kAlignment = 8;
@@ skipping 452 matching lines @@
 const int kMessageRequestIDOffset = kMessageFlagsOffset + 4;
 const int kMessageExpectsResponse = 1 << 0;
 const int kMessageIsResponse = 1 << 1;
 
 class Message {
   ByteData buffer;
   List<core.RawMojoHandle> handles;
 
   Message(this.buffer, this.handles);
 
-  int getHeaderNumBytes() => buffer.getUint32(kStructHeaderNumBytesOffset);
-  int getHeaderNumFields() => buffer.getUint32(kStructHeaderNumFieldsOffset);
-  int getName() => buffer.getUint32(kMessageNameOffset);
-  int getFlags() => buffer.getUint32(kMessageFlagsOffset);
-  bool isResponse() => (getFlags() & kMessageIsResponse) != 0;
-  bool expectsResponse() => (getFlags() & kMessageExpectsResponse) != 0;
-
-  void setRequestID(int id) {
-    buffer.setUint64(kMessageRequestIDOffset, id);
-  }
+  int get headerNumBytes =>
+      buffer.getUint32(kStructHeaderNumBytesOffset, Endianness.LITTLE_ENDIAN);
+  int get headerNumFields =>
+      buffer.getUint32(kStructHeaderNumFieldsOffset, Endianness.LITTLE_ENDIAN);
+  int get name =>
+      buffer.getUint32(kMessageNameOffset, Endianness.LITTLE_ENDIAN);
+  int get flags =>
+      buffer.getUint32(kMessageFlagsOffset, Endianness.LITTLE_ENDIAN);
+  int get requestID =>
+      buffer.getUint64(kMessageRequestIDOffset, Endianness.LITTLE_ENDIAN);
+      set requestID(int id) =>
+      buffer.setUint64(kMessageRequestIDOffset, id, Endianness.LITTLE_ENDIAN);
+  bool get isResponse => (flags & kMessageIsResponse) != 0;
+  bool get expectsResponse => (flags & kMessageExpectsResponse) != 0;
 }
 
 
 class MessageBuilder {
   MojoEncoder encoder;
   List<core.RawMojoHandle> handles;
 
   MessageBuilder._();
 
   MessageBuilder(int name, int payloadSize) {
@@ skipping 267 matching lines @@
   Map decode(MojoDecoder decoder) => decoder.decodeMapPointer(key, val);
   void encode(MojoEncoder encoder, Map map) {
     encoder.encodeMapPointer(key, val, map);
   }
 }
 
 
 class NullableMapOf extends MapOf {
   NullableMapOf(Object key, Object val) : super(key, val);
 }