Dart: Simplifies the handle watcher. Various cleanups and bugfixes.

mojo/dart/embedder/test/dart_to_cpp_tests.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/at_exit.h"
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 231 matching lines @@
 };
 
 }  // namespace
 
 class DartToCppTest : public testing::Test {
  public:
   DartToCppTest() {}
 
   bool RunTest(const std::string& test, CppSideConnection* cpp_side) {
     // Putting Dart on its own thread so we can use Dart_RunLoop (called from
-    // DartController::runDartScript) and base::RunLoop::Run together. Passing
+    // DartController::RunDartScript) and base::RunLoop::Run together. Passing
     // the thread to RunWithDartOnThread instead of inlining that function here
     // so that we are sure the MessagePipe destructor runs and closes the
     // handles on the C++ side before the Thread destructor runs and joins on
     // the Dart thread. Closing the handles on the C++ side must happen first
     // because it is the client, and therefore the Dart side will run and not
     // join while handles are still open, until the C++ side closes them.
     base::Thread dart_thread("dart");
     cpp_side->set_run_loop(&run_loop_);
     return RunWithDartOnThread(&dart_thread, test, cpp_side);
   }
@@ skipping 105 matching lines @@
 TEST_F(DartToCppTest, Echo) {
   EchoCppSideConnection cpp_side_connection;
   bool unhandled_exception =
       RunTest("dart_to_cpp_tests.dart", &cpp_side_connection);
   EXPECT_TRUE(cpp_side_connection.DidSucceed());
   EXPECT_FALSE(unhandled_exception);
 }
 
 }  // namespace dart
 }  // namespace mojo