PushRegistration.unregister(), cleanups and more tests.

public/platform/WebPushProvider.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebPushProvider_h
 #define WebPushProvider_h
 
 #include "public/platform/WebCallbacks.h"
 #include "public/platform/WebCommon.h"
 #include "public/platform/WebPushPermissionStatus.h"
@@ skipping 23 matching lines @@
     // Takes ownership of the WebPushRegistrationCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
     virtual void getRegistration(WebServiceWorkerRegistration*, WebPushRegistrationCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
 
     // Takes ownership of the WebPushPermissionStatusCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
     virtual void getPermissionStatus(WebServiceWorkerRegistration*, WebPushPermissionStatusCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
 
     // Takes ownership if the WebPushUnregisterCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
-    virtual void unregister(WebServiceWorkerRegistration*, WebPushUnregisterCallbacks* callback)
-    {
-        // FIXME: this should call BLINK_ASSERT_NOT_REACHED() when Chromium will
-        // have an implementation.
-        bool result = true;
-        callback->onSuccess(&result);
-        delete callback;
-    }
+    virtual void unregister(WebServiceWorkerRegistration*, WebPushUnregisterCallbacks* callback) { BLINK_ASSERT_NOT_REACHED(); }
 };
 
 } // namespace blink
 
 #endif // WebPushProvider_h