Issue 800483006: Remove CascadeScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 800483006: Remove CascadeScope. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove CascadeScope. It's always zero in sky. This was for sorting tree boundary crossing rules and rules in multiple ShadowRoots on the same element. Neither of those things exist in Sky so we can remove it. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3ecfae009ec16c128bc47d6d84bb30a6261c9de5

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -30 lines)			Patch
M	sky/engine/core/css/ElementRuleCollector.h	View	4 chunks	+6 lines, -11 lines	0 comments	Download
M	sky/engine/core/css/ElementRuleCollector.cpp	View	5 chunks	+9 lines, -12 lines	0 comments	Download
M	sky/engine/core/css/resolver/ScopedStyleResolver.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/css/resolver/ScopedStyleResolver.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleResolver.cpp	View	1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

esprehn

5 years, 11 months ago (2015-01-09 02:02:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3ecfae009ec16c128bc47d6d84bb30a6261c9de5 (presubmit successful).