chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc - Issue 800473006: Don't include hidden windows in IsAppWindowRegisteredInAnyProfile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

Issue 800473006: Don't include hidden windows in IsAppWindowRegisteredInAnyProfile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/app_window_registry_util.cc ('K') | « chrome/browser/ui/apps/apps_metro_handler_win.cc ('k') | chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

diff --git a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

index 010767274aaaccc4c0fd03e4f1ef69e1267bb8e4..7c09672090c7dffcc9d07782e1f507c3452231a1 100644

--- a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

+++ b/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc

@@ -151,7 +151,7 @@ bool QuitWithAppsController::ShouldQuit() {

// Quit immediately if there are no packaged app windows or hosted apps open

// or the confirmation has been suppressed. Ignore panels.

- if (!AppWindowRegistryUtil::IsAppWindowRegisteredInAnyProfile(

+ if (!AppWindowRegistryUtil::IsAppWindowVisibleInAnyProfile(

extensions::AppWindow::WINDOW_TYPE_DEFAULT) &&

!hosted_apps_open) {

return true;

@@ -159,7 +159,7 @@ bool QuitWithAppsController::ShouldQuit() {

} else {

// Quit immediately if there are no windows or the confirmation has been

// suppressed.

- if (!AppWindowRegistryUtil::IsAppWindowRegisteredInAnyProfile(

+ if (!AppWindowRegistryUtil::IsAppWindowVisibleInAnyProfile(

extensions::AppWindow::WINDOW_TYPE_DEFAULT))

return true;

}