chrome/browser/app_controller_mac.mm - Issue 800473006: Don't include hidden windows in IsAppWindowRegisteredInAnyProfile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 800473006: Don't include hidden windows in IsAppWindowRegisteredInAnyProfile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/app_controller_mac.mm

diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm

index 082dccab046b169296cf157d0182ff3d5f4a63d8..3ffafd0099c9498bc8360f8f38e885f18ecbfebf 100644

--- a/chrome/browser/app_controller_mac.mm

+++ b/chrome/browser/app_controller_mac.mm

@@ -473,7 +473,7 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {

- (NSApplicationTerminateReply)applicationShouldTerminate:(NSApplication*)app {

// If there are no windows, quit immediately.

if (chrome::BrowserIterator().done() &&

- !AppWindowRegistryUtil::IsAppWindowRegisteredInAnyProfile(0)) {

+ !AppWindowRegistryUtil::IsAppWindowVisibleInAnyProfile(0)) {

return NSTerminateNow;

}

« no previous file with comments | « no previous file | chrome/browser/apps/app_shim/app_shim_handler_mac.cc » ('j') | chrome/browser/apps/app_window_registry_util.cc » ('J')