Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: runtime/vm/regexp_assembler.h

Issue 800433004: Use a typed array for the irregexp stack. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: whitespace Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/regexp_assembler.h
diff --git a/runtime/vm/regexp_assembler.h b/runtime/vm/regexp_assembler.h
index 12edecbb468180d7e869e4e8b301b20dc30cd63b..2e4276bb81e0f4e55960c0a8a1bf84f2dd2fa22a 100644
--- a/runtime/vm/regexp_assembler.h
+++ b/runtime/vm/regexp_assembler.h
@@ -539,7 +539,10 @@ class IRRegExpMacroAssembler : public RegExpMacroAssembler {
// Accessors for our local stack_.
void PushStack(Definition* definition);
- Value* PopStack();
+ Definition* PopStack();
+ Definition* PeekStack();
+ void CheckStackLimit();
+ void GrowStack();
// Prints the specified argument. Used for debugging.
void Print(PushArgumentInstr* argument);
@@ -595,6 +598,7 @@ class IRRegExpMacroAssembler : public RegExpMacroAssembler {
// A list, acting as the runtime stack for both backtrack locations and
// stored positions within the string.
LocalVariable* stack_;
+ LocalVariable* stack_tip_;
// Stores the current character within the string.
LocalVariable* current_character_;
@@ -629,7 +633,7 @@ class IRRegExpMacroAssembler : public RegExpMacroAssembler {
const intptr_t saved_registers_count_;
// The actual array objects used for the stack and registers.
- GrowableObjectArray& stack_array_;
+ Array& stack_array_cell_;
TypedData& registers_array_;
IdAllocator block_id_;

Powered by Google App Engine
This is Rietveld 408576698