Search for history items that was imported from IE is not working.

chrome/utility/importer/ie_importer_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/importer/ie_importer_win.h"
 
 #include <ole2.h>
 #include <intshcut.h>
 #include <shlobj.h>
 #include <urlhist.h>
@@ skipping 459 matching lines @@
 }
 
 void IEImporter::ImportHistory() {
   const std::string kSchemes[] = {url::kHttpScheme,
                                   url::kHttpsScheme,
                                   url::kFtpScheme,
                                   url::kFileScheme};
   int total_schemes = arraysize(kSchemes);
 
   base::win::ScopedComPtr<IUrlHistoryStg2> url_history_stg2;
-  HRESULT result;
-  result = url_history_stg2.CreateInstance(CLSID_CUrlHistory, NULL,
-                                           CLSCTX_INPROC_SERVER);
-  if (FAILED(result))
+  if (FAILED(url_history_stg2.CreateInstance(CLSID_CUrlHistory, NULL,
+                                             CLSCTX_INPROC_SERVER))) {
     return;
+  }
   base::win::ScopedComPtr<IEnumSTATURL> enum_url;
-  if (SUCCEEDED(result = url_history_stg2->EnumUrls(enum_url.Receive()))) {
+  if (SUCCEEDED(url_history_stg2->EnumUrls(enum_url.Receive()))) {
     std::vector<ImporterURLRow> rows;
     STATURL stat_url;
-    ULONG fetched;
+
+    // IEnumSTATURL::Next() doesn't fill STATURL::dwFlags by default. Need to
+    // call IEnumSTATURL::SetFilter() with STATURL_QUERYFLAG_TOPLEVEL flag to
+    // specify that STATURL::dwFlags will indicate whether this URL is dated

[gab, 2014/12/23 22:00:58]

I prefered your previous wording, e.g. something like:

"... to specfic how STATURL::dwFlags will be filled."

(I find the latest slightly confusing for a new reader)

[Alexey Seren, 2014/12/24 07:23:19]

Acknowledged. Changed to previous comment.

+    // (top level). First argument of IEnumSTATURL::SetFilter() specifies the
+    // URL prefix that is used by IEnumSTATURL::Next() for filtering items by
+    // URL. So need to pass an empty string here to get all history items.
+    enum_url->SetFilter(L"", STATURL_QUERYFLAG_TOPLEVEL);
     while (!cancelled() &&
-           (result = enum_url->Next(1, &stat_url, &fetched)) == S_OK) {
+           enum_url->Next(1, &stat_url, NULL) == S_OK) {
       base::string16 url_string;
       if (stat_url.pwcsUrl) {
         url_string = stat_url.pwcsUrl;
         CoTaskMemFree(stat_url.pwcsUrl);
       }
       base::string16 title_string;
       if (stat_url.pwcsTitle) {
         title_string = stat_url.pwcsTitle;
         CoTaskMemFree(stat_url.pwcsTitle);
       }
 
       GURL url(url_string);
       // Skips the URLs that are invalid or have other schemes.
       if (!url.is_valid() ||
           (std::find(kSchemes, kSchemes + total_schemes, url.scheme()) ==
            kSchemes + total_schemes))
         continue;
 
       ImporterURLRow row(url);
       row.title = title_string;
       row.last_visit = base::Time::FromFileTime(stat_url.ftLastVisited);
-      if (stat_url.dwFlags == STATURL_QUERYFLAG_TOPLEVEL) {
+      if (stat_url.dwFlags == STATURLFLAG_ISTOPLEVEL) {
         row.visit_count = 1;
         row.hidden = false;
       } else {
+        DCHECK(!stat_url.dwFlags);

[gab, 2014/12/23 22:00:58]

As in code provided in previous comment, add this comment here:

// dwFlags should only contain the STATURLFLAG_ISTOPLEVEL bit per
// the filter set above.

[Alexey Seren, 2014/12/24 07:23:19]

Acknowledged.

         row.hidden = true;
       }
 
       rows.push_back(row);
     }
 
     if (!rows.empty() && !cancelled()) {
       bridge_->SetHistoryItems(rows, importer::VISIT_SOURCE_IE_IMPORTED);
     }
   }
@@ skipping 347 matching lines @@
   static int version = -1;
   if (version < 0) {
     wchar_t buffer[128];
     DWORD buffer_length = sizeof(buffer);
     base::win::RegKey reg_key(HKEY_LOCAL_MACHINE, kIEVersionKey, KEY_READ);
     LONG result = reg_key.ReadValue(L"Version", buffer, &buffer_length, NULL);
     version = ((result == ERROR_SUCCESS)? _wtoi(buffer) : 0);
   }
   return version;
 }