Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 800423002: Synchronize PRESUBMIT.py with CQ (Closed)

Created:
6 years ago by Paweł Hajdan Jr.
Modified:
6 years ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M PRESUBMIT.py View 1 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Paweł Hajdan Jr.
6 years ago (2014-12-15 13:57:36 UTC) #2
Sergiy Byelozyorov
lgtm w/ comments https://codereview.chromium.org/800423002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/800423002/diff/1/PRESUBMIT.py#newcode1794 PRESUBMIT.py:1794: 'android_clang_dbg_recipe', nit:keep these two sorted too ...
6 years ago (2014-12-15 16:19:19 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/800423002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/800423002/diff/1/PRESUBMIT.py#newcode1794 PRESUBMIT.py:1794: 'android_clang_dbg_recipe', On 2014/12/15 16:19:19, Sergiy Byelozyorov wrote: > nit:keep ...
6 years ago (2014-12-15 16:26:11 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/847e1faba078ff86d0d43744f3b00457cf190f5c Cr-Commit-Position: refs/heads/master@{#308359}
6 years ago (2014-12-15 16:28:11 UTC) #5
Paweł Hajdan Jr.
6 years ago (2014-12-15 16:28:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
847e1faba078ff86d0d43744f3b00457cf190f5c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698