Issue 800393003: Fix type annotation to pass the closure compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 800393003: Fix type annotation to pass the closure compiler. (Closed)

Created:
6 years ago by fukino

Modified:
6 years ago

Reviewers:
yawano

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix type annotation to pass the closure compiler. Trivial fix to make the closure's Buildbot green. http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux BUG=none TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default TBR=yawano@chromium.org Committed: https://crrev.com/5aec1872b75e47312096c1216af1c782c9198844 Cr-Commit-Position: refs/heads/master@{#308339}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800393003/1

6 years ago (2014-12-15 11:45:21 UTC) #3

commit-bot: I haz the power

6 years ago (2014-12-15 12:34:09 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5aec1872b75e47312096c1216af1c782c9198844
Cr-Commit-Position: refs/heads/master@{#308339}