Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 800363002: Revert "Add UMA Histogram Manager to Cronet." (Closed)

Created:
6 years ago by Andre
Modified:
6 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add UMA Histogram Manager to Cronet." This reverts commit 4eb0fd47de0736f3f4c970e8d7f8813ef2177886. HistogramManagerBucketFields times out on Win7 Tests. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/33548 TBR=rtenneti@chromium.org,asvitkine@chromium.org,mef@chromium.org NOTREECHECKS=true NOTRY=true BUG=441466 Committed: https://crrev.com/c81147dfd02bfd04282dbbba5af8fc5918dc9380 Cr-Commit-Position: refs/heads/master@{#308315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -480 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M components/cronet.gypi View 4 chunks +0 lines, -6 lines 0 comments Download
M components/cronet/android/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/android/cronet_loader.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D components/cronet/android/histogram_manager.h View 1 chunk +0 lines, -16 lines 0 comments Download
D components/cronet/android/histogram_manager.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D components/cronet/android/java/src/org/chromium/net/HistogramManager.java View 1 chunk +0 lines, -25 lines 0 comments Download
D components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HistogramManagerTest.java View 1 chunk +0 lines, -34 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java View 2 chunks +0 lines, -3 lines 0 comments Download
M components/metrics.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
D components/metrics/histogram_encoder.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/metrics/histogram_encoder.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D components/metrics/histogram_encoder_unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D components/metrics/histogram_manager.h View 1 chunk +0 lines, -62 lines 0 comments Download
D components/metrics/histogram_manager.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D components/metrics/histogram_manager_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M components/metrics/metrics_log.cc View 2 chunks +30 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800363002/1
6 years ago (2014-12-15 05:19:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 05:19:48 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-15 05:20:29 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c81147dfd02bfd04282dbbba5af8fc5918dc9380
Cr-Commit-Position: refs/heads/master@{#308315}

Powered by Google App Engine
This is Rietveld 408576698