Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 800343004: OOP PDF: Fix PrintWebViewHelper test issues with OOP PDF enabled. (Closed)

Created:
6 years ago by Sam McNally
Modified:
6 years ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OOP PDF: Fix PrintWebViewHelper test issues with OOP PDF enabled. OOP PDF causes that the print-preview page to contain an iframe of the PDF extension instead of directly including a plugin element. However, the tests for PrintWebViewHelper use a fake print-preview page that cannot contain an iframe of the extension because the necessary infrastructure is not available in the test. This relaxes the expectations so that in tests where the pdf element isn't an iframe, that element is used instead. BUG=303491 Committed: https://crrev.com/81c98ba5f74cbe9e6f1a12a0b96371b65dd4374e Cr-Commit-Position: refs/heads/master@{#308450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/renderer/printing/print_web_view_helper.cc View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
6 years ago (2014-12-15 06:09:34 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years ago (2014-12-15 22:16:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800343004/1
6 years ago (2014-12-15 22:18:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 23:20:08 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 23:21:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81c98ba5f74cbe9e6f1a12a0b96371b65dd4374e
Cr-Commit-Position: refs/heads/master@{#308450}

Powered by Google App Engine
This is Rietveld 408576698