Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 800293002: Log V8 version in profiler log file. (Closed)

Created:
6 years ago by bnoordhuis
Modified:
6 years ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Visibility:
Public.

Description

Log V8 version in profiler log file.

Patch Set 1 #

Patch Set 2 : Log V8 version in profiler log file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M src/log-utils.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M test/cctest/test-log.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
bnoordhuis
Makes it possible to match tick processors to log files.
6 years ago (2014-12-13 21:41:33 UTC) #2
Yang
On 2014/12/13 21:41:33, bnoordhuis wrote: > Makes it possible to match tick processors to log ...
6 years ago (2014-12-15 19:25:36 UTC) #3
bnoordhuis
On 2014/12/15 19:25:36, Yang wrote: > On 2014/12/13 21:41:33, bnoordhuis wrote: > > Makes it ...
6 years ago (2014-12-15 20:55:53 UTC) #4
caitp (gmail)
On 2014/12/15 20:55:53, bnoordhuis wrote: > On 2014/12/15 19:25:36, Yang wrote: > > On 2014/12/13 ...
6 years ago (2014-12-15 20:58:51 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-15 21:22:13 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-15 21:32:20 UTC) #11
bnoordhuis
On 2014/12/15 19:25:36, Yang wrote: > On 2014/12/13 21:41:33, bnoordhuis wrote: > > Makes it ...
6 years ago (2014-12-15 21:33:46 UTC) #12
Yang
I'm in vacation for another two weeks, and with a phone I can't do much. ...
6 years ago (2014-12-16 05:26:21 UTC) #14
Sven Panne
6 years ago (2014-12-16 07:41:11 UTC) #15
On 2014/12/16 05:26:21, Yang wrote:
> I'm in vacation for another two weeks, and with a phone I can't do much. I
think
> what might be going on is that you are not using the new git workflow, so the
> upload script doesnt base it off the correct revision?
> 
> I'm adding Sven. Not sure if he is not already on vacation as well though.

Landed via https://codereview.chromium.org/806143002/ (needed clang-format to
make the presubmit step happy).

Powered by Google App Engine
This is Rietveld 408576698