Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 800263002: Added incident report for variations seed signature mismatch. (Closed)

Created:
6 years ago by grt (UTC plus 2)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added incident report for variations seed signature mismatch. - Keep record of a bad signature in VariationsSeedStore::LoadSeed. - Register VerifyVariationsSeedSignature in SafeBrowsingService::RegisterAllDelayedAnalysis to send an incident report, if a bad signature is encountered. Originally by georgesak@chromium.org in https://codereview.chromium.org/646733002/. BUG=423467 TBR=asvitkine@chromium.org,mattm@chromium.org Committed: https://crrev.com/7d52139ca255b4985cc61c72abb79ea6ec7476de Cr-Commit-Position: refs/heads/master@{#308370}

Patch Set 1 : Original CL from issue 646733002 #

Patch Set 2 : analyze on UI thread to access variations service #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -13 lines) Patch
M chrome/browser/metrics/variations/variations_seed_store.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc View 5 chunks +13 lines, -5 lines 0 comments Download
A chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.h View 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_handlers.h View 1 chunk +27 lines, -0 lines 0 comments Download
A + chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_handlers.cc View 2 chunks +7 lines, -8 lines 0 comments Download
A chrome/browser/safe_browsing/incident_reporting/variations_seed_signature_incident_handlers_unittest.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/safe_browsing/csd.proto View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
grt (UTC plus 2)
This resolves the wrong-thread DCHECK problem with the original submission. I'll land this with TBR ...
6 years ago (2014-12-13 14:36:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800263002/20001
6 years ago (2014-12-15 16:03:51 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 18:04:44 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7d52139ca255b4985cc61c72abb79ea6ec7476de Cr-Commit-Position: refs/heads/master@{#308370}
6 years ago (2014-12-15 18:05:29 UTC) #6
Alexei Svitkine (slow)
5 years, 11 months ago (2015-01-05 18:23:29 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698