Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 800193006: [Cleanup] Add CreateWebContentsWithID helper to TabStripModelTest (Closed)

Created:
5 years, 11 months ago by johnme
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Add CreateWebContentsWithID helper to TabStripModelTest Since SetID is usually called immediately after CreateWebContents, this lets you do both at once to improve legibility/conciseness. Committed: https://crrev.com/d2ba9ec2f1bd12bf49fae11063ed2f79d547dc6d Cr-Commit-Position: refs/heads/master@{#310441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -27 lines) Patch
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 8 chunks +18 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
johnme
5 years, 11 months ago (2015-01-07 22:50:17 UTC) #2
sky
LGTM
5 years, 11 months ago (2015-01-07 23:23:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800193006/1
5 years, 11 months ago (2015-01-08 00:51:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 02:09:23 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 02:12:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2ba9ec2f1bd12bf49fae11063ed2f79d547dc6d
Cr-Commit-Position: refs/heads/master@{#310441}

Powered by Google App Engine
This is Rietveld 408576698