ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h - Issue 800183005: Adding UMA stats for dragdrop events for both touch and mouse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

Issue 800183005: Adding UMA stats for dragdrop events for both touch and mouse. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: All errors removed, Adding UMA stats to track usage of DragAndDrop on ChromeOS, X11, and Windows. A… Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/base/dragdrop/drag_drop_types.h ('k') | ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc » ('j') | ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

index 880aa5d69772c5da2e29402b1360b4982927e62a..4c82a3114f6efdcf876166cdaaac695487826bd3 100644

--- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

+++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h

@@ -6,7 +6,9 @@

#define UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_DRAG_DROP_CLIENT_AURAX11_H_

#include <X11/Xlib.h>

#include <set>

+#include <utility>

mfomitchev 2015/01/13 17:01:25 Doesn't seem like this should be needed.

caelyn 2015/01/13 23:48:58 Added because lint suggested it, removing it and a

#include <vector>

#include "base/compiler_specific.h"

@@ -262,6 +264,9 @@ class VIEWS_EXPORT DesktopDragDropClientAuraX11

// The operation bitfield as requested by StartDragAndDrop.

int drag_operation_;

+ // The DragEventSource as reported by StartDragAndDrop.

+ ui::DragDropTypes::DragEventSource current_drag_event_source_;

// We offer the other window a list of possible operations,

// XdndActionsList. This is the requested action from the other window. This

// is DRAG_NONE if we haven't sent out an XdndPosition message yet, haven't