Issue 800143002: Reland: Update DisplayConfigurator to use the asynchronous tasks

Issue 800143002: Reland: Update DisplayConfigurator to use the asynchronous tasks (Closed)

Created:
6 years ago by dnicoara

Modified:
6 years ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@async-refactor4

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Reland: Update DisplayConfigurator to use the asynchronous tasks Original review: https://codereview.chromium.org/801493002/ BUG=429746 TESTS=display_unittests with ASAN TBR=derat@chromium.org Committed: https://crrev.com/65d9d31230c1775ce29589e199722f2598a4162e Cr-Commit-Position: refs/heads/master@{#308228}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+583 lines, -577 lines)			Patch
M	ui/display/chromeos/configure_displays_task.cc	View	1	1 chunk	+11 lines, -9 lines	0 comments	Download
M	ui/display/chromeos/display_configurator.h	View		10 chunks	+52 lines, -49 lines	0 comments	Download
M	ui/display/chromeos/display_configurator.cc	View		9 chunks	+447 lines, -437 lines	0 comments	Download
M	ui/display/chromeos/display_configurator_unittest.cc	View		14 chunks	+73 lines, -82 lines	0 comments	Download

Total messages: 7 (2 generated)

dnicoara

PTAL Looks like I missed one important use after free :( Patchset 1 is the ...

6 years ago (2014-12-13 00:14:23 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800143002/20001

6 years ago (2014-12-13 02:15:25 UTC) #4

commit-bot: I haz the power

Patchset 2 (id:??) landed as https://crrev.com/65d9d31230c1775ce29589e199722f2598a4162e Cr-Commit-Position: refs/heads/master@{#308228}

6 years ago (2014-12-13 02:31:37 UTC) #6

Message was sent while issue was closed.

lgtm