Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 800133002: Release resources from SurfaceAggregator when new frame arrives. (Closed)

Created:
6 years ago by jbauman
Modified:
6 years ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Release resources from SurfaceAggregator when new frame arrives. The SurfaceAggregator will never need the resources for a frame after a new frame has been submitted for that Surface, so return the resources early. BUG=441698, 441751, 440213 Committed: https://crrev.com/3e5ec5ff4db2a2d5952c84b6b189b834f2084f89 Cr-Commit-Position: refs/heads/master@{#308236}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M cc/surfaces/display.cc View 1 chunk +4 lines, -1 line 1 comment Download
M cc/surfaces/surface_aggregator.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
6 years ago (2014-12-12 23:11:03 UTC) #2
jamesr
lgtm https://codereview.chromium.org/800133002/diff/1/cc/surfaces/display.cc File cc/surfaces/display.cc (right): https://codereview.chromium.org/800133002/diff/1/cc/surfaces/display.cc#newcode174 cc/surfaces/display.cc:174: aggregator_->ReleaseResources(surface); it's a little fragile here that we ...
6 years ago (2014-12-13 01:54:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800133002/1
6 years ago (2014-12-13 01:57:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-13 03:12:37 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-13 03:13:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e5ec5ff4db2a2d5952c84b6b189b834f2084f89
Cr-Commit-Position: refs/heads/master@{#308236}

Powered by Google App Engine
This is Rietveld 408576698