Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: Source/core/inspector/InspectorInstrumentation.cpp

Issue 800113002: Use C++11 range-based for loop in Source/core/inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: REBASE AGAIN! Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 } 110 }
111 111
112 void continueWithPolicyIgnoreImpl(LocalFrame* frame, DocumentLoader* loader, uns igned long identifier, const ResourceResponse& r) 112 void continueWithPolicyIgnoreImpl(LocalFrame* frame, DocumentLoader* loader, uns igned long identifier, const ResourceResponse& r)
113 { 113 {
114 didReceiveResourceResponseButCanceledImpl(frame, loader, identifier, r); 114 didReceiveResourceResponseButCanceledImpl(frame, loader, identifier, r);
115 } 115 }
116 116
117 void willDestroyResourceImpl(Resource* cachedResource) 117 void willDestroyResourceImpl(Resource* cachedResource)
118 { 118 {
119 if (!instrumentingAgentsSet) 119 if (!instrumentingAgentsSet)
120 return; 120 return;
pfeldman 2014/12/16 16:52:10 InstrumentingAgents* instrumentingAgents : ..
zhaoze.zhou 2014/12/16 18:56:40 Done.
121 HashSet<InstrumentingAgents*>::iterator end = instrumentingAgentsSet->end(); 121 for (auto it : *instrumentingAgentsSet) {
122 for (HashSet<InstrumentingAgents*>::iterator it = instrumentingAgentsSet->be gin(); it != end; ++it) { 122 InstrumentingAgents* instrumentingAgents = it;
123 InstrumentingAgents* instrumentingAgents = *it;
124 if (InspectorResourceAgent* inspectorResourceAgent = instrumentingAgents ->inspectorResourceAgent()) 123 if (InspectorResourceAgent* inspectorResourceAgent = instrumentingAgents ->inspectorResourceAgent())
125 inspectorResourceAgent->willDestroyResource(cachedResource); 124 inspectorResourceAgent->willDestroyResource(cachedResource);
126 } 125 }
127 } 126 }
128 127
129 bool collectingHTMLParseErrorsImpl(InstrumentingAgents* instrumentingAgents) 128 bool collectingHTMLParseErrorsImpl(InstrumentingAgents* instrumentingAgents)
130 { 129 {
131 if (InspectorInspectorAgent* inspectorAgent = instrumentingAgents->inspector InspectorAgent()) 130 if (InspectorInspectorAgent* inspectorAgent = instrumentingAgents->inspector InspectorAgent())
132 return inspectorAgent->hasFrontend(); 131 return inspectorAgent->hasFrontend();
133 return false; 132 return false;
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 263
265 InstrumentingAgents* instrumentationForWorkerGlobalScope(WorkerGlobalScope* work erGlobalScope) 264 InstrumentingAgents* instrumentationForWorkerGlobalScope(WorkerGlobalScope* work erGlobalScope)
266 { 265 {
267 if (WorkerInspectorController* controller = workerGlobalScope->workerInspect orController()) 266 if (WorkerInspectorController* controller = workerGlobalScope->workerInspect orController())
268 return controller->m_instrumentingAgents.get(); 267 return controller->m_instrumentingAgents.get();
269 return 0; 268 return 0;
270 } 269 }
271 270
272 } // namespace blink 271 } // namespace blink
273 272
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698