Use C++11 range-based for loop in Source/core/inspector

Source/core/inspector/InspectorPageAgent.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 323 matching lines @@
 }
 
 Resource* InspectorPageAgent::cachedResource(LocalFrame* frame, const KURL& url)
 {
     Document* document = frame->document();
     if (!document)
         return 0;
     Resource* cachedResource = document->fetcher()->cachedResource(url);
     if (!cachedResource) {
         Vector<Document*> allImports = InspectorPageAgent::importsForFrame(frame);
-        for (Vector<Document*>::const_iterator it = allImports.begin(); it != allImports.end(); ++it) {
-            Document* import = *it;
+        for (Document* import : allImports) {
             cachedResource = import->fetcher()->cachedResource(url);
             if (cachedResource)
                 break;
         }
     }
     if (!cachedResource)
         cachedResource = memoryCache()->resourceForURL(url, document->fetcher()->getCacheIdentifier());
     return cachedResource;
 }
 
@@ skipping 265 matching lines @@
     ListHashSet<Cookie>::iterator it = cookiesList.begin();
     for (int i = 0; it != end; ++it, i++)
         cookies->addItem(buildObjectForCookie(*it));
 
     return cookies;
 }
 
 static void cachedResourcesForDocument(Document* document, Vector<Resource*>& result, bool skipXHRs)
 {
     const ResourceFetcher::DocumentResourceMap& allResources = document->fetcher()->allResources();
-    ResourceFetcher::DocumentResourceMap::const_iterator end = allResources.end();
-    for (ResourceFetcher::DocumentResourceMap::const_iterator it = allResources.begin(); it != end; ++it) {
-        Resource* cachedResource = it->value.get();
+    for (const auto& resource : allResources) {
+        Resource* cachedResource = resource.value.get();
 
         switch (cachedResource->type()) {
         case Resource::Image:
             // Skip images that were not auto loaded (images disabled in the user agent).
             if (toImageResource(cachedResource)->stillNeedsLoad())
                 continue;
             break;
         case Resource::Font:
             // Skip fonts that were referenced in CSS but never used/downloaded.
             if (toFontResource(cachedResource)->stillNeedsLoad())
@@ skipping 41 matching lines @@
     return result;
 }
 
 static Vector<KURL> allResourcesURLsForFrame(LocalFrame* frame)
 {
     Vector<KURL> result;
 
     result.append(urlWithoutFragment(frame->loader().documentLoader()->url()));
 
     Vector<Resource*> allResources = cachedResourcesForFrame(frame, false);
-    for (Vector<Resource*>::const_iterator it = allResources.begin(); it != allResources.end(); ++it)
-        result.append(urlWithoutFragment((*it)->url()));
+    for (const auto& resource : allResources)
+        result.append(urlWithoutFragment(resource->url()));
 
     return result;
 }
 
 void InspectorPageAgent::getCookies(ErrorString*, RefPtr<TypeBuilder::Array<TypeBuilder::Page::Cookie> >& cookies)
 {
     ListHashSet<Cookie> rawCookiesList;
 
     for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext(mainFrame())) {
         if (!frame->isLocalFrame())
             continue;
         Document* document = toLocalFrame(frame)->document();
         Vector<KURL> allURLs = allResourcesURLsForFrame(toLocalFrame(frame));
-        for (Vector<KURL>::const_iterator it = allURLs.begin(); it != allURLs.end(); ++it) {
+        for (const auto& url : allURLs) {
             Vector<Cookie> docCookiesList;
-            getRawCookies(document, *it, docCookiesList);
+            getRawCookies(document, url, docCookiesList);
             int cookiesSize = docCookiesList.size();
             for (int i = 0; i < cookiesSize; i++) {
                 if (!rawCookiesList.contains(docCookiesList[i]))
                     rawCookiesList.add(docCookiesList[i]);
             }
         }
     }
 
     cookies = buildArrayForCookies(rawCookiesList);
 }
@@ skipping 259 matching lines @@
     }
 }
 
 void InspectorPageAgent::didClearDocumentOfWindowObject(LocalFrame* frame)
 {
     if (!m_frontend)
         return;
 
     RefPtr<JSONObject> scripts = m_state->getObject(PageAgentState::pageAgentScriptsToEvaluateOnLoad);
     if (scripts) {
-        JSONObject::const_iterator end = scripts->end();
-        for (JSONObject::const_iterator it = scripts->begin(); it != end; ++it) {
+        for (const auto& script : *scripts) {
             String scriptText;
-            if (it->value->asString(&scriptText))
+            if (script.value->asString(&scriptText))
                 frame->script().executeScriptInMainWorld(scriptText);
         }
     }
     if (!m_scriptToEvaluateOnLoadOnce.isEmpty())
         frame->script().executeScriptInMainWorld(m_scriptToEvaluateOnLoadOnce);
 }
 
 void InspectorPageAgent::domContentLoadedEventFired(LocalFrame* frame)
 {
     if (!frame->isMainFrame())
@@ skipping 284 matching lines @@
 
 PassRefPtr<TypeBuilder::Page::FrameResourceTree> InspectorPageAgent::buildObjectForFrameTree(LocalFrame* frame)
 {
     RefPtr<TypeBuilder::Page::Frame> frameObject = buildObjectForFrame(frame);
     RefPtr<TypeBuilder::Array<TypeBuilder::Page::FrameResourceTree::Resources> > subresources = TypeBuilder::Array<TypeBuilder::Page::FrameResourceTree::Resources>::create();
     RefPtr<TypeBuilder::Page::FrameResourceTree> result = TypeBuilder::Page::FrameResourceTree::create()
          .setFrame(frameObject)
          .setResources(subresources);
 
     Vector<Resource*> allResources = cachedResourcesForFrame(frame, true);
-    for (Vector<Resource*>::const_iterator it = allResources.begin(); it != allResources.end(); ++it) {
-        Resource* cachedResource = *it;
-
+    for (Resource* cachedResource : allResources) {
         RefPtr<TypeBuilder::Page::FrameResourceTree::Resources> resourceObject = TypeBuilder::Page::FrameResourceTree::Resources::create()
             .setUrl(urlWithoutFragment(cachedResource->url()).string())
             .setType(cachedResourceTypeJson(*cachedResource))
             .setMimeType(cachedResource->response().mimeType());
         if (cachedResource->wasCanceled())
             resourceObject->setCanceled(true);
         else if (cachedResource->status() == Resource::LoadError)
             resourceObject->setFailed(true);
         subresources->addItem(resourceObject);
     }
 
     Vector<Document*> allImports = InspectorPageAgent::importsForFrame(frame);
-    for (Vector<Document*>::const_iterator it = allImports.begin(); it != allImports.end(); ++it) {
-        Document* import = *it;
+    for (Document* import : allImports) {
         RefPtr<TypeBuilder::Page::FrameResourceTree::Resources> resourceObject = TypeBuilder::Page::FrameResourceTree::Resources::create()
             .setUrl(urlWithoutFragment(import->url()).string())
             .setType(resourceTypeJson(InspectorPageAgent::DocumentResource))
             .setMimeType(import->suggestedMIMEType());
         subresources->addItem(resourceObject);
     }
 
     RefPtr<TypeBuilder::Array<TypeBuilder::Page::FrameResourceTree> > childrenArray;
     for (Frame* child = frame->tree().firstChild(); child; child = child->tree().nextSibling()) {
         if (!child->isLocalFrame())
@@ skipping 176 matching lines @@
 void InspectorPageAgent::trace(Visitor* visitor)
 {
     visitor->trace(m_page);
     visitor->trace(m_injectedScriptManager);
     visitor->trace(m_inspectorResourceContentLoader);
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink