Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 800103005: Release GPU resources only after renderer GPU channels are closed. (Closed)

Created:
6 years ago by GusFernandez
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman, spang, halliwell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Release GPU resources only after renderer GPU channels are closed. The RelinquishGpuResource message from the browser process may come before or after the rederer process closes it GPU channel. As such, we need to wait until only the Browser GPU channel is open until we can actually release the default off-screen PBuffer surface and the EGL display. This is a follow-up to https://codereview.chromium.org/712343003 Bug: 18724066 BUG=432268 Committed: https://crrev.com/aec301ce2f19d24b7e7e4033f041e47b7c3820cb Cr-Commit-Position: refs/heads/master@{#308468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M content/common/gpu/gpu_channel_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 5 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
GusFernandez
6 years ago (2014-12-15 20:14:41 UTC) #2
GusFernandez
6 years ago (2014-12-15 21:46:25 UTC) #4
piman
lgtm
6 years ago (2014-12-15 21:51:37 UTC) #5
GusFernandez
+halliwell
6 years ago (2014-12-15 22:08:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800103005/1
6 years ago (2014-12-15 22:09:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 00:07:41 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-16 00:08:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aec301ce2f19d24b7e7e4033f041e47b7c3820cb
Cr-Commit-Position: refs/heads/master@{#308468}

Powered by Google App Engine
This is Rietveld 408576698