Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 800083003: Remove hasSyntacticallyValidCSSHeader. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove hasSyntacticallyValidCSSHeader. This existed apparently to track if a CSS file had at least a valid CSS rule at the start to attempt to mitigate cross origin CSS attacks where a file with an invalid mime was sniffed as CSS and then we skipped the first part which was not valid, but then interpreted the latter half of the file as valid CSS. In Sky all content is same origin, so we don't need this mitigation. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/98e32a064da97322fa816070c20f99cea4fff5a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -35 lines) Patch
M sky/engine/core/css/StyleSheetContents.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 3 chunks +1 line, -15 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-12 22:23:00 UTC) #2
ojan
lgtm
6 years ago (2014-12-12 23:35:12 UTC) #3
esprehn
6 years ago (2014-12-12 23:44:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
98e32a064da97322fa816070c20f99cea4fff5a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698