Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 800073004: [turbofan] Recursively reduce new inputs of changed nodes. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Recursively reduce new inputs of changed nodes. The GraphReducer should recurse into new inputs after a node was changed. Most of the reducers already assume this behavior, and it mostly worked by accident in many cases. R=svenpanne@chromium.org Committed: https://crrev.com/d0a7ef938ad54e5df867f14c27cb88a20786e573 Cr-Commit-Position: refs/heads/master@{#25861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
M src/compiler/graph-reducer.cc View 1 chunk +41 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
6 years ago (2014-12-17 10:12:40 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-17 10:15:13 UTC) #2
Sven Panne
lgtm
6 years ago (2014-12-17 10:23:12 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as d0a7ef938ad54e5df867f14c27cb88a20786e573 (presubmit successful).
6 years ago (2014-12-17 10:32:00 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-17 10:32:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0a7ef938ad54e5df867f14c27cb88a20786e573
Cr-Commit-Position: refs/heads/master@{#25861}

Powered by Google App Engine
This is Rietveld 408576698