Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 800073003: win: Avoid warnings about conversion to smaller integer types (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@strlcpy-impl
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Avoid warnings about conversion to smaller integer types e.g. d:\src\crashpad\crashpad\util\numeric\in_range_cast.h(35) : warning C4244: 'return' : conversion from 'unsigned __int64' to 'uint32_t', possible loss of data d:\src\crashpad\crashpad\util\numeric\in_range_cast.h(35) : warning C4244: 'return' : conversion from '__int64' to 'int32_t', possible loss of data d:\src\crashpad\crashpad\util\numeric\in_range_cast_test.cc(54) : see reference to function template instantiation 'Destination crashpad::InRangeCast<int32_t,__int64>(Source,Destination)' being compiled with [ Destination=int32_t , Source=__int64 ] R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1a17e7e6434fe883f8d7fc7f3a899c082446b0e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M util/numeric/in_range_cast.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scottmg
6 years ago (2014-12-15 22:36:00 UTC) #1
Mark Mentovai
LGTM
6 years ago (2014-12-15 23:39:23 UTC) #2
scottmg
6 years ago (2014-12-16 00:19:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a17e7e6434fe883f8d7fc7f3a899c082446b0e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698